Closed
Bug 279323
Opened 21 years ago
Closed 21 years ago
nsCSSScanner constructor requires ifdef CSS_REPORT_PARSE_ERRORS
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: WeirdAl, Assigned: WeirdAl)
Details
Attachments
(1 file)
|
774 bytes,
patch
|
dbaron
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
Removing CSS_REPORT_PARSE_ERRORS in nsCSSScanner.h leads to a compile failure in
nsCSSScanner.cpp:
r:/mozilla.org\mozilla\layout\style\nsCSSScanner.cpp(179) : error C2065:
'mErrorBuf' : undeclared identifier
r:/mozilla.org\mozilla\layout\style\nsCSSScanner.cpp(179) : error C2070:
''unknown-type'': illegal sizeof operand
r:/mozilla.org\mozilla\layout\style\nsCSSScanner.cpp(179) : error C3861:
'mErrorBuf': identifier not found, even with argument-dependent lookup
r:/mozilla.org\mozilla\layout\style\nsCSSScanner.cpp(179) : error C3861:
'mErrorBuf': identifier not found, even with argument-dependent lookup
r:/mozilla.org\mozilla\layout\style\nsCSSScanner.cpp(180) : error C2614:
'nsCSSScanner' : illegal member initialization: 'mError' is not a base or member
make[1]: *** [nsCSSScanner.obj] Error 2
Patch coming right up.
|
Assignee | |
Comment 1•21 years ago
|
||
Attachment #172057 -
Flags: review?(dbaron)
Attachment #172057 -
Flags: review?(dbaron) → review+
|
|
Assignee | |
Updated•21 years ago
|
Attachment #172057 -
Flags: superreview?(bzbarsky)
|
||
Comment 2•21 years ago
|
||
Comment on attachment 172057 [details] [diff] [review]
patch, v1 (add ifdef)
Lemme know if you need this landed.
Attachment #172057 -
Flags: superreview?(bzbarsky) → superreview+
|
|
||
Updated•21 years ago
|
Assignee: dbaron → ajvincent
|
|
Assignee | |
Comment 3•21 years ago
|
||
fixed by bz's checkin
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•