279535 - [FIX] disabling and then enabling image view doesn't show images again

Status: VERIFIED FIXED

(SeaMonkey :: Preferences, defect)

Description

[Nirav Patel]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a6) Gecko/20050111
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a6) Gecko/20050111

disable images in pages and then enabling them again doesn't show the images
again...images are now not at all displayed no matter how many times the image
acceptance policy is changed (enable/disable)



Reproducible: Always

Steps to Reproduce:
1. disable the image in pages
2. enable it to show all images
3. well that's it, no way to reproduces....

Actual Results:  
i can't see images on pages now.....

Expected Results:  
it has to show images on each pages

Comment 1

[Mats Palmgren (inactive)]

"Image Acceptance Policy" does not seem to work at all for me,
Mozilla 2005-01-22-05 trunk Linux.
I set it to "Do not load any images" but it does load them, even after restart.
This occurs both with an old profile and freshly created one.

Comment 2

[Boris Zbarsky [:bzbarsky]]

That sounds pretty serious....

mvl, did you break this?  Mats, do you still see this in a build with bug 279782
fixed?

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

this works for, with both the tools->image manager menu and the preferences.
Nirav, if this is still a problem with the latest nightlies, can you give more
detailed steps to reproduce?

Comment 4

[Mats Palmgren (inactive)]

(In reply to comment #2)
> Mats, do you still see this in a build with bug 279782 fixed?

Yes, I still see this with 2005-02-04-06 trunk Linux. Both with an old profile
and a freshly created one, even after restart.

STEPS TO REPRODUCE:
1. Install http://ftp.mozilla.org/pub/mozilla.org/mozilla/nightly/latest/
   into an empty directory
2. Click Preferences->Privacy&Security->Images->Image Acceptance Policy:
   "Do no load any images"
3. load http://www.cnn.com  (images are shown)
4. exit
5. start and goto http://www.cnn.com (images are shown)
   (I verified that the pref survived the restart)

Comment 5

[Mats Palmgren (inactive)]

Attachment: prefs.js for the fresh profile used in tests

Comment 6

[Mats Palmgren (inactive)]

Comment on attachment 173388 [details]
prefs.js for the fresh profile used in tests

... after I had set the "Do not load any images" that is.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Confirming based on Mats' data.

Comment 8

[Michiel van Leeuwen (email: mvl+moz@)]

I still can't reproduce. the pref just works.
This sounds like bug 280670, but the fix should be in the latest builds.

Also, the pref is set correctly:
user_pref("permissions.default.image", 2);
2 is deny
(http://lxr.mozilla.org/seamonkey/source/netwerk/base/public/nsIPermissionManager.idl#78)

So i don't get it. Would there be a reason that libpermissions.so would not
load? Is there anything for libpermissions and/or @mozilla.org/permissionmanager
in mozilla/components/compreg.dat?

Comment 9

[Mats Palmgren (inactive)]

I used mozilla-i686-pc-linux-gnu-full-installer.tar.gz  if that matters...

Comment 10

[Mats Palmgren (inactive)]

... it does - I tried mozilla-i686-pc-linux-gnu-gtk2+xft.tar.gz and
mozilla-i686-pc-linux-gnu.tar.gz and those works fine.
So, it seems this an installer problem.

Comment 11

[Boris Zbarsky [:bzbarsky]]

Was libpermissions.so added to the installer manifests?

Comment 12

[Michiel van Leeuwen (email: mvl+moz@)]

ehm, no. I suck

Comment 13

[Michiel van Leeuwen (email: mvl+moz@)]

now i really suck for hitting random radiobuttons :( sorry for the spam.

Comment 14

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: patch v1

patch adds the permissions so/dll to unix and os2. I'm not sure if i should add
it to packages-win too, given that cookie.dll and wallet.dll are both not in
there. Is windows always static?

Comment 15

[Darin Fisher]

Comment on attachment 173396 [details] [diff] [review]
patch v1

ack!  sr=darin

Comment 16

[Darin Fisher]

we don't build seamonkey statically on any platforms.

Comment 17

[Michiel van Leeuwen (email: mvl+moz@)]

patch checked in

Comment 18

[Mats Palmgren (inactive)]

Verified fixed, 2005-03-24-05 trunk Linux.