279645 - New Download prefs need to be included in HELP.

Status: RESOLVED FIXED

(Documentation Graveyard :: Help Viewer, defect)

Description

[Patrick]

The new download prefs from the pref window are not included in HELP yet.

1) "When saving a file"
2) "When a download completes"

Since at least the first one is mentioned in the Moz 1.8 release notes under
"what's new" i guess they should be included before 1.8 is released.

Couldn't find this yet...
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b) Gecko/20050115

Comment 1

[Mats Palmgren (inactive)]

*** Bug 279644 has been marked as a duplicate of this bug. ***

Comment 2

[Stefan [:stefanh]]

Yes, we should fix this before 1.8b is released...

Comment 3

[Giacomo Magnini]

Attachment: First cut, just a template. Someone else should fill in the blanks! :-)

Comment 4

[Stefan [:stefanh]]

Attachment: second cut...

Comment 5

[Stefan [:stefanh]]

OK, I see if I can polish the patch on Sunday. My imagination seems gone
today... Feedback is welcome!

Comment 6

[Patrick]

+        use.To listen to the sound you&apos;ve chosened, click Preview.</li>

space between "use." and "To".
"chosened" = "chosen"

Comment 7

[Stefan [:stefanh]]

Attachment: Final version

Thanks for catching those ugly errors, Patrick.

Fixed a few oddities in mail_help as well.

Comment 8

[Ian Neal]

Comment on attachment 172882 [details] [diff] [review]
Final version

>Index: resources/locale/en-US/cs_nav_prefs_navigator.xhtml
>+      <li><strong>Play a sound</strong>: Select this if you want
>+        &brandShortName; to play a custom sound (in WAW format) when a download
I would suggest changing the bit in brackets to:
(typically in WAV format)

as Windows do WAVs but other platforms (well Macs) can play other formats.

>+        is completed. Enter the path to the sound file or use the Browse button
>+        to select it in the file locator. To listen to the sound you&apos;ve
>+        chosen, click Preview.</li>
This is incorrect as the text field is read only so currently you can only
browse to the sound file - it may change later but the help will have to change
at that point.

>Index: resources/locale/en-US/mail_help.xhtml
> You can choose between the default system sound and a custom sound in
> WAV format. If you choose the latter you have to enter the path to the
>-sound file or use the Browse button to select in in the file locator.
>-Click on the Preview button to preview the choosen sound file.
>+sound file or use the Browse button to select it in the file locator.
>+Click on the Preview button to listen to the chosen sound file.

As above, WAV format again (though the prefs text mentions .wav incorrectly -
so perhaps leave in and log the changing of ".wav" to "sound" as a new bug and
alter the help then) and text field is read only so can only browse.

With those changes r=me

Comment 9

[Stefan [:stefanh]]

Attachment: New version (checked in)

New version addressing Ians comments. I left the WAV stuff untouched in
mail_help and changed the copyright line in the two altered files.

Can you check in the patch, please?

Comment 10

[Ian Neal]

Comment on attachment 172903 [details] [diff] [review]
New version (checked in)

Checking in cs_nav_prefs_navigator.xhtml;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/cs_nav_prefs_navigator.
xhtml,v  <--  cs_nav_prefs_navigator.xhtml
new revision: 1.25; previous revision: 1.24
done
Checking in mail_help.xhtml;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/mail_help.xhtml,v  <-- 
mail_help.xhtml
new revision: 1.51; previous revision: 1.50
done

Comment 11

[Stefan [:stefanh]]

thx Ian!