Closed
Bug 279697
Opened 20 years ago
Closed 20 years ago
[FIX]crash if getter/setter elements are placed outside of property element
Categories
(Core :: XBL, defect, P1)
Core
XBL
Tracking
()
RESOLVED
FIXED
mozilla1.8beta1
People
(Reporter: surkov, Assigned: bzbarsky)
References
Details
Attachments
(3 files)
492 bytes,
text/xml
|
Details | |
325 bytes,
application/vnd.mozilla.xul+xml
|
Details | |
1.76 KB,
patch
|
jst
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a6) Gecko/20050111 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a6) Gecko/20050111 In instance: <binding id="binding1"> <implementation> <getter> </getter> </implementation> </binding> Reproducible: Always Steps to Reproduce:
Comment 1•20 years ago
|
||
Could you make a testcase and attach it here? Also, if you installed Talkback.exe along with your build, could you attach the Incident ID # once you've sent an incident as feedback to the server? Thanks
Keywords: stackwanted
Reporter | ||
Comment 2•20 years ago
|
||
Reporter | ||
Comment 3•20 years ago
|
||
Reporter | ||
Comment 4•20 years ago
|
||
Unfortunately I can't send incident as feedback to server.
Comment 5•20 years ago
|
||
Alexandar, I don't crash with the 2005-01-24-05 trunk WinXP build. Can you try with the latest nightly available from ftp.mozilla.org?
Assignee | ||
Comment 6•20 years ago
|
||
Alexander, want a hint? Once you attach the XBL, actually point the XUL to the attachment so it doesn't have to be downloaded to be tested. I bet this is what confused Stephen -- he loaded your testcase, and didn't crash (since the XBL wasn't loaded). I can reproduce the crash if I save both files to disk with the right names (which you didn't even indicate in the attachment comments....)
Assignee | ||
Comment 7•20 years ago
|
||
This just bails out on getters/setters in unexpected places.
Assignee: hyatt → bzbarsky
Status: UNCONFIRMED → ASSIGNED
Attachment #172370 -
Flags: superreview?(jst)
Attachment #172370 -
Flags: review?(jst)
Assignee | ||
Updated•20 years ago
|
OS: Windows 2000 → All
Priority: -- → P1
Hardware: PC → All
Summary: crash if getter/setter elements are placed outside of property element → [FIX]crash if getter/setter elements are placed outside of property element
Target Milestone: --- → mozilla1.8beta
Assignee | ||
Updated•20 years ago
|
Keywords: stackwanted
Comment 8•20 years ago
|
||
Comment on attachment 172370 [details] [diff] [review] Patch r+sr=jst
Attachment #172370 -
Flags: superreview?(jst)
Attachment #172370 -
Flags: superreview+
Attachment #172370 -
Flags: review?(jst)
Attachment #172370 -
Flags: review+
Assignee | ||
Comment 9•20 years ago
|
||
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 10•20 years ago
|
||
To comment #6. You're right. I assumed ingenuous that anybody knows how my test can be ran. Do you advise me to give good comments of attached files? Is there a way to attach testcases so that it doesn't confuse anybody?
Assignee | ||
Comment 11•20 years ago
|
||
Yes, if you point the XUL at the version of the XBL that you've already attached then just loading the XUL directly from bugzilla will show the bug.... That's what I suggested in comment 6, no?
Reporter | ||
Comment 12•20 years ago
|
||
Yes, for sure. My english prevents me from understanding of your comments :)
Assignee | ||
Comment 13•19 years ago
|
||
*** Bug 286181 has been marked as a duplicate of this bug. ***
You need to log in
before you can comment on or make changes to this bug.
Description
•