279697 - [FIX]crash if getter/setter elements are placed outside of property element

Status: RESOLVED FIXED

(Core :: XBL, defect, P1)

Description

[alexander :surkov (:asurkov)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a6) Gecko/20050111
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a6) Gecko/20050111

In instance:

<binding id="binding1">
<implementation>
  <getter>
  </getter>
</implementation>
</binding>

Reproducible: Always

Steps to Reproduce:

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Could you make a testcase and attach it here?  Also, if you installed
Talkback.exe along with your build, could you attach the Incident ID # once
you've sent an incident as feedback to the server?

Thanks

Comment 2

[alexander :surkov (:asurkov)]

Attachment: binding

Comment 3

[alexander :surkov (:asurkov)]

Attachment: testcase

Comment 4

[alexander :surkov (:asurkov)]

Unfortunately I can't send incident as feedback to server.

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Alexandar, I don't crash with the 2005-01-24-05 trunk WinXP build.  Can you try
with the latest nightly available from ftp.mozilla.org?

Comment 6

[Boris Zbarsky [:bzbarsky]]

Alexander, want a hint?  Once you attach the XBL, actually point the XUL to the
attachment so it doesn't have to be downloaded to be tested.  I bet this is what
confused Stephen -- he loaded your testcase, and didn't crash  (since the XBL
wasn't loaded).

I can reproduce the crash if I save both files to disk with the right names
(which you didn't even indicate in the attachment comments....)

Comment 7

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch

This just bails out on getters/setters in unexpected places.

Comment 8

[Johnny Stenback (:jst)]

Comment on attachment 172370 [details] [diff] [review]
Patch

r+sr=jst

Comment 9

[Boris Zbarsky [:bzbarsky]]

Fixed.

Comment 10

[alexander :surkov (:asurkov)]

To comment #6.
You're right. I assumed ingenuous that anybody knows how my test can be ran. Do
you advise me to give good comments of attached files?  Is there a way to attach
testcases so that it doesn't confuse anybody?

Comment 11

[Boris Zbarsky [:bzbarsky]]

Yes, if you point the XUL at the version of the XBL that you've already attached
then just loading the XUL directly from bugzilla will show the bug....  That's
what I suggested in comment 6, no?

Comment 12

[alexander :surkov (:asurkov)]

Yes, for sure. My english prevents me from understanding of your comments :)

Comment 13

[Boris Zbarsky [:bzbarsky]]

*** Bug 286181 has been marked as a duplicate of this bug. ***