Closed Bug 280248 Opened 20 years ago Closed 20 years ago

Expose <q> to MSAA

Categories

(Core :: Disability Access APIs, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: aaronlev, Assigned: aaronlev)

Details

(Keywords: access)

Attachments

(1 file)

We currently expose blockquote, but we forgot to add q.

Needed for Window-Eyes support.
Comment on attachment 172734 [details] [diff] [review]
Add ::q to if () for generic accessible creation. Atom was already defined.

>diff -p -u -5 -r1.123 nsAccessibilityService.cpp
>--- accessible/src/base/nsAccessibilityService.cpp	26 Jan 2005 22:41:05 -0000	1.123
>+++ accessible/src/base/nsAccessibilityService.cpp	28 Jan 2005 20:56:39 -0000
>@@ -450,10 +450,11 @@ nsAccessibilityService::CreateHTMLAccess
> #endif
>   else if (content->HasAttr(kNameSpaceID_None, nsAccessibilityAtoms::tabindex) 
> #ifndef MOZ_ACCESSIBILITY_ATK
>            ||
>            tag == nsAccessibilityAtoms::blockquote ||
>+           tag == nsAccessibilityAtoms::q ||
>            tag == nsAccessibilityAtoms::form ||

Can you keep these listed in alphabetical order?
Attachment #172734 - Flags: review?(pkwarren) → review+
> Can you keep these listed in alphabetical order?
I can, but I wanted the 2 kinds of quotes together.

I'll check it in alphabetically. 

Attachment #172734 - Flags: superreview?(bzbarsky)
Attachment #172734 - Flags: superreview?(bzbarsky) → superreview+
Checking in nsAccessibilityService.cpp;
/cvsroot/mozilla/accessible/src/base/nsAccessibilityService.cpp,v  <-- 
nsAccessibilityService.cpp
new revision: 1.124; previous revision: 1.123
done
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: