280264 - XForms submission doesn't remove non-relevant instance-data.

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Doron Rosenberg (IBM)]

Also, bug 279449 adds another loop walking the data, which should be combined
with the submission serialization code probably at one point.

Comment 1

[Doron Rosenberg (IBM)]

-> moi

Comment 2

[Doron Rosenberg (IBM)]

Attachment: first try

Comment 3

[aaronr]

Comment on attachment 174313 [details] [diff] [review]
first try

+nsXFormsModelElement::IsInstanceDataValid(nsIDOMNode *aInstanceDataNode,
PRBool *aResult)

You should sign a value into aResult before you do NS_ENSURE_STATE

nsXFormsModelElement::IsInstanceDataRelevant(nsIDOMNode *aInstanceDataNode,
PRBool *aResult)

same here

nsXFormsModelElement::IsInstanceDataRequired(nsIDOMNode *aInstanceDataNode,
PRBool *aResult)

same here

I'd also suggest, like we talked about, one function that can handle getting
the nodestate just the once and all 3 tests and return the proper value. To get
rid of all of the extaneous function calling.

Comment 4

[Doron Rosenberg (IBM)]

Attachment: 2nd try

Comment 5

[Doron Rosenberg (IBM)]

Attachment: 3rd try

Comment 6

[Doron Rosenberg (IBM)]

Attachment: hopefully aaron has no more comments.

Comment 7

[aaronr]

Comment on attachment 174414 [details] [diff] [review]
hopefully aaron has no more comments.

for posterity sake, my comments were:

In nsXFormsModelElement::HandleInstanceDataNode
- make return values a const and give them similar names that make sense.
- assign default return value.
- Change test syntax so that you don't re-assign same return value that is
already contained in the return parameter.
- probably don't need the NS_ENSURE_ARG_POINTER tests because this function
should only ever be called from one place where the passed in parameter pointer
can be assured.

Looks fine now

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 174414 [details] [diff] [review]
hopefully aaron has no more comments.

Didn't test yet, but looks good. r=me

Comment 9

[Doron Rosenberg (IBM)]

checked in.