280554 - SVG content and layout frames should use GetAnimVal not GetBaseVal

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Scooter Morris]

Currently, we get values from nsSVGAnimated* by using GetBaseVal.  This will
make ever doing animations very difficult.  We should call GetAnimVal insted.

Comment 1

[Scooter Morris]

Attachment: Patch that switches everything to using GetAnimVal

Comment 2

[Alex Fritze]

Comment on attachment 173012 [details] [diff] [review]
Patch that switches everything to using GetAnimVal

The layout changes look good. Not so sure about the content changes - do we
really want the animvals here? I guess it doesn't matter. What about this one
though:

>Index: content/svg/content/src/nsSVGMarkerElement.cpp
>===================================================================
> /* void setOrientToAngle (in nsIDOMSVGAngle angle); */
> NS_IMETHODIMP nsSVGMarkerElement::SetOrientToAngle(nsIDOMSVGAngle *angle)
> {
>   mOrientType->SetBaseVal(SVG_MARKER_ORIENT_ANGLE);
> 
>   nsIDOMSVGAngle *a;
>-  mOrientAngle->GetBaseVal(&a);
>+  mOrientAngle->GetAnimVal(&a);
>   float f;
>   angle->GetValue(&f);
>   a->SetValue(f);

Shouldn't this remain GetBaseVal()?

Comment 3

[Scooter Morris]

Attachment: Updated to not change to GetAnimVal in nsSVGMarkerElement::SetOrientToAngle

Comment 4

[Scooter Morris]

Checked in by [e-mail]: 2/2/2005