281026 - Script warning - continue fails to continue

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Bob Clary [:bc] (inactive)]

Run the ecma/Date/15.9.5.10-2.js test

Expected result: 
Stop Script dialog appears, 
click continue to finish script

Actual result  : 
Stop Script dialog appears, 
click continue, 
dialog reappears immediately.

I think bug 145523 caused this by removing code to reset the branch call back
time. This worked in a 2005-02-02/winxp trunk build but does not in a
2005-02-03/winxp trunk build.

    // Allow the script to run this long again                                  
    ctx->mBranchCallbackTime = PR_Now();

Comment 1

[Vidar Haarr (not reading bugmail)]

Yes, I have no idea why I removed that line, sorry.
I'll produce a patch tonight.

Comment 2

[Vidar Haarr (not reading bugmail)]

Attachment: version 0.1 (Checked in)

The problem was that I based my patch on the earlier patch in bug 145523, and
jst's review comments in
<https://bugzilla.mozilla.org/show_bug.cgi?id=145523#c16>. Between then and
now, nallen created <https://bugzilla.mozilla.org/attachment.cgi?id=141103> and
jst r/sr'ed it.

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 173492 [details] [diff] [review]
version 0.1 (Checked in)

Duh, yeah. r+sr=jst

Comment 4

[Ian Neal]

Comment on attachment 173492 [details] [diff] [review]
version 0.1 (Checked in)

Checking in nsJSEnvironment.cpp;
/cvsroot/mozilla/dom/src/base/nsJSEnvironment.cpp,v  <--  nsJSEnvironment.cpp
new revision: 1.241; previous revision: 1.240
done

Comment 5

[Vidar Haarr (not reading bugmail)]

Thanks for the reviews and checkin!
FIXED.

bc: can you verify?

Comment 6

[Bob Clary [:bc] (inactive)]

seems to work in a fresh build. I will verify with tomorrow's nightly. Thanks!

Comment 7

[Bob Clary [:bc] (inactive)]

verified fixed in 20050210 winxp build. thanks.