Closed Bug 281101 Opened 21 years ago Closed 21 years ago

Return CHILDID_SELF for get_accFocus on currently focused accessible

Categories

(Core :: Disability Access APIs, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: aaronlev, Assigned: aaronlev)

Details

(Keywords: access)

Attachments

(1 file)

Our current behavior breaks some Window-Eyes commands that deal with text editing. Currently we always return VT_EMPTY on non-document accessibles for the focused child. We should return CHILDID_SELF if the current accessible has focus.
Attached patch Simple patch — — Splinter Review
Attachment #173398 - Flags: superreview?(bryner)
Attachment #173398 - Flags: review?(pkwarren)
Your comment doesn't match the code: + // We return CHILD_ID_SELF if we currently have focus Shouldn't that be CHILDID_SELF?
Comment on attachment 173398 [details] [diff] [review] Simple patch r=pkw after fixing the comment issue addressed by the comment above.
Attachment #173398 - Flags: review?(pkwarren) → review+
Attachment #173398 - Flags: superreview?(bryner) → superreview+
Checking in nsDocAccessibleWrap.cpp; /cvsroot/mozilla/accessible/src/msaa/nsDocAccessibleWrap.cpp,v <-- nsDocAccessibleWrap.cpp new revision: 1.21; previous revision: 1.20 done
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: