281339 - gtk_im_context_set_cursor_location() is not used so the candidate window for Input method is not shown correct position.

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Hiroyuki Ikezoe (:hiro)]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20050116 Debian/1.7.5-1.im
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20050116 Debian/1.7.5-1.im

gtk_im_context_set_cursor_location() is not used so candidate window for Input
Method does not shown correct position.



Reproducible: Always

Steps to Reproduce:
1. load the page which has textare.
2. focus to the textarea
3. turn on input method ( not kinput2, use uim<http://freedesktop.org/Software/uim>)
4. type some characters
5. press space key to convert it.


Actual Results:  
the conversion window is shown on top left of the rendering region.


Expected Results:  
the conversion window is shown under the caret.


compiling with --enable-default-toolkit=gtk2

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: the patch to fix

I am a substitute of the creator (Takuro Ashie) of this patch.

This patch works fine as much as I confirmed.
Please review it.

Thanks.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

I'm sorry. I made a mistake.

the conversion window is wrong. I mean the candidate window.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Attachment: a screenshot of wrong position

a screenshot of wrong candidate window position

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Attachment: a screenshot of correct candidate window position (after patching)

Comment 5

[Takuro Ashie]

Same problem is reporoduced when I using IIIMF
(http://www.openi18n.org/modules.php?op=modload&name=Sections&file=index&req=viewarticle&artid=30&page=1)
and SCIM (http://www.scim-im.org/).

This patch will fix these problems.

Comment 6

[Takuro Ashie]

Attachment: Candidate window position of IIIMF is also wrong

Comment 7

[Boris Zbarsky [:bzbarsky]]

Checked in.  Thank you for the patch!

Comment 8

[Ervin Yan]

still wrong preedit position on Sun JDS chinese locale, see bug 283136. a
snapshot is attached in that bug.

on Sun JDS chinese locale, the preedit string will be shown with an IIIM
auxiliary window, and will not be rendered by applications, so IMEComposeStart()
and IMEComposeText() will not be called in such situations.
 

Comment 9

[Ervin Yan]

I have attached a new patch in bug 283136, could you whether the patch is also
fixed your cases.