281390 - Investigate removing nsIContent* from nsIFrame::AttributeChanged

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Vidar Haarr (not reading bugmail)]

As noted in bug 270708 comment 6, we can probably remove this argument, since it
will (should?) always be the mContent of the frame.

bz also noted that "It's null in very rare cases (viewport and page frames). 
It's non-null otherwise.".

I'll provide a patch some day.

Comment 1

[Vidar Haarr (not reading bugmail)]

Attachment: version 0.1

Stab 1 at this.
These ones are the interesting ones, I think:
generic/nsFrameFrame: nsSubDocumentFrame
xul/nsNativeScrollbarFrame
xul/nsScrollbarFrame

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 195122 [details] [diff] [review]
version 0.1

Looks great!

Comment 3

[Vidar Haarr (not reading bugmail)]

Thanks for the review and checkin, bz!

Comment 4

[R.K.Aa.]

I always modify all.js in greprefs (WinXP) to read 
pref("middlemouse.scrollbarPosition", true);

But now, when I click, I get the "scroll icon". The page also "jumps" to clicked
position, but I have to click once more to get rid of that square scroll-icon,
and in the meanwhile the page scrolls/wobbles a little. I didn't use to get
that. It's happened sometime the last week and it is, to put it bluntly, a major
PITA.
The only checkin last week mentioning "scroll"-anything is for this bug.

Any chance of a fix?

Comment 5

[R.K.Aa.]

It's worse than I thought: The scrolling also happens when I middle-mouse paste
in forms

Comment 6

[Boris Zbarsky [:bzbarsky]]

Christine, this bug is VERY unlikely to have caused the problem you're seeing. 
Could you please file a bug with clear steps to reproduce (including which exact
browser you're using, which extensions are needed, what pref values need to be
set to what, etc), and cc me on it?