Closed
Bug 281725
Opened 20 years ago
Closed 20 years ago
Remove some obsolete images in en-US/images
Categories
(SeaMonkey :: Help Documentation, defect)
SeaMonkey
Help Documentation
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: stefanh, Assigned: stefanh)
Details
Attachments
(1 file, 2 obsolete files)
3.17 KB,
patch
|
iannbugzilla
:
review+
caillon
:
approval1.8b+
|
Details | Diff | Splinter Review |
There are some old gif images in the image dir that are not used: key.gif newmail.gif pen.gif sick.gif smile.gif Also, pen.gif and newmail.gif are in jar.mn ...
Assignee | ||
Comment 1•20 years ago
|
||
At least this will save some footprint. The images listed above has to be cvs removed as well.
Attachment #173896 -
Flags: review?(bugzilla)
Comment on attachment 173896 [details] [diff] [review] jar.mn image reference removal >- locale/en-US/help/images/help_print.gif (locale/en-US/images/help_print.gif) >+ locale/en-US/help/images/help_print.gif (locale/en-US/images/help_print.gif) Trailing spaces at the end of this entry could be removed too. >- locale/en-US/help/images/newmail.gif (locale/en-US/images/newmail.gif) >- locale/en-US/help/images/mail_flag_column.png (locale/en-US/images/mail_flag_column.png) >- locale/en-US/help/images/mail_flag.png (locale/en-US/images/mail_flag.png) >+ locale/en-US/help/images/mail_flag_column.png (locale/en-US/images/mail_flag_column.png) >+ locale/en-US/help/images/mail_flag.png (locale/en-US/images/mail_flag.png) The second entries could be lined up too. >@@ -79,7 +77,7 @@ > locale/en-US/help/images/table.gif (locale/en-US/images/table.gif) > locale/en-US/help/images/task_mail.png (locale/en-US/images/task_mail.png) > locale/en-US/help/images/task_newmail.png (locale/en-US/images/task_newmail.png) >- locale/en-US/help/images/taskbar-ab.png (locale/en-US/images/taskbar-ab.png) >+ locale/en-US/help/images/taskbar-ab.png (locale/en-US/images/taskbar-ab.png) Again the second entries could be lined up too. r= with those changes
Attachment #173896 -
Flags: review?(bugzilla) → review+
Assignee | ||
Comment 3•20 years ago
|
||
New version addressing Ians comments.
Attachment #173896 -
Attachment is obsolete: true
Attachment #173995 -
Flags: review+
Assignee | ||
Comment 4•20 years ago
|
||
Comment on attachment 173995 [details] [diff] [review] New version Simple, small footprint-reducer. Patch+removal of obsolete images.
Attachment #173995 -
Flags: approval1.8b?
Comment 5•20 years ago
|
||
(In reply to comment #0) > Also, pen.gif and newmail.gif are in jar.mn ... newmail.gif still exists in jar.mn with your patch....
Assignee | ||
Comment 6•20 years ago
|
||
(In reply to comment #5) > newmail.gif still exists in jar.mn with your patch.... Here's the correct version. Sorry.
Attachment #173995 -
Attachment is obsolete: true
Attachment #174133 -
Flags: review+
Assignee | ||
Comment 7•20 years ago
|
||
Comment on attachment 173995 [details] [diff] [review] New version Clearing obsolete approval request.
Attachment #173995 -
Flags: approval1.8b?
Assignee | ||
Updated•20 years ago
|
Attachment #174133 -
Flags: approval1.8b?
Comment 8•20 years ago
|
||
Comment on attachment 174133 [details] [diff] [review] Correct version (Checked in) a=caillon for 1.8b
Attachment #174133 -
Flags: approval1.8b? → approval1.8b+
Assignee | ||
Comment 9•20 years ago
|
||
Ian, can you check in the patch and remove the obsolete images, please.
Comment 10•20 years ago
|
||
Comment on attachment 174133 [details] [diff] [review] Correct version (Checked in) Checking in jar.mn; /cvsroot/mozilla/extensions/help/resources/jar.mn,v <-- jar.mn new revision: 1.65; previous revision: 1.64 done Removing locale/en-US/images/key.gif; /cvsroot/mozilla/extensions/help/resources/locale/en-US/images/key.gif,v <-- key.gif new revision: delete; previous revision: 1.1 done Removing locale/en-US/images/newmail.gif; /cvsroot/mozilla/extensions/help/resources/locale/en-US/images/newmail.gif,v <-- newmail.gif new revision: delete; previous revision: 1.6 done Removing locale/en-US/images/pen.gif; /cvsroot/mozilla/extensions/help/resources/locale/en-US/images/pen.gif,v <-- pen.gif new revision: delete; previous revision: 1.2 done Removing locale/en-US/images/sick.gif; /cvsroot/mozilla/extensions/help/resources/locale/en-US/images/sick.gif,v <-- sick.gif new revision: delete; previous revision: 1.2 done Removing locale/en-US/images/smile.gif; /cvsroot/mozilla/extensions/help/resources/locale/en-US/images/smile.gif,v <-- smile.gif new revision: delete; previous revision: 1.2 done
Attachment #174133 -
Attachment description: Correct version → Correct version (Checked in)
Assignee | ||
Comment 11•20 years ago
|
||
--> Fixed
Comment 12•20 years ago
|
||
Really marking as fixed for Stefan
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•