282010 - Messages for offline use are not downloaded when reading news online

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Sven Grull]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b) Gecko/20050210
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b) Gecko/20050210

I have selected several news groups for offline use. Normally I sync the news
groups before reading. In this case messages are downloaded from news server
correctly. 
Compared to former builds reading the same news groups online the messages are
not downloaded while reading for later offline use anymore.

Reproducible: Always

Steps to Reproduce:
1. Select a news group for offline use.
2. Open this news group while online.
3. Select a new message.
4. Switch to offline.
5. Try to read the former selected message again.
Actual Results:  
Message body is not downloaded.

Expected Results:  
Message body should be readable.

Same happens in recent Thunderbird trunk builds.

Comment 1

[Frank Wein [:mcsmurf]]

(In reply to comment #0)
> Compared to former builds reading the same news groups online the messages are
> not downloaded while reading for later offline use anymore.

So this is a regression then? What was the last build, where this didn't occour?

Comment 2

[Sven Grull]

This regressed between 2005020406 and 2005020522.

Comment 3

[David :Bienvenu]

recreated this.

Comment 4

[Asa Dotzler [:asa]]

major feature breakage. adding blocking flag.

Comment 5

[David :Bienvenu]

Attachment: proposed fix

the line passed to NotifyDownloadedLine now contains the native line
terminator, so we need to account for that.

Comment 6

[(not reading, please use [e-mail] instead)]

Comment on attachment 174322 [details] [diff] [review]
proposed fix

a=sspitzer

Comment 7

[Sven Grull]

Sorry to bother you... could it be that this patch broke download/sync of news
messages? With build 2005021503 messages are downloaded again while reading but
download/sync for offline use is broken.
If I should file another bug please let me know.

Comment 8

[David :Bienvenu]

yikes, yes, argh, sorry.

Comment 9

[David :Bienvenu]

Attachment: fix for regression

downloading for offline also needs to get the linebreak from readnextline, and
check for the last line differently. That was the only other caller of
NotifyDownloadLine, so this should fix it all.

Comment 10

[Sven Grull]

There is another problem that I just realized. Perhaps this will also be fixed
with the new patch.
I had some messages in my database that were not displayed after syncing.
Checking them in the database file I found out that they were written in a
single line to the file without any linke break like this:
Path: uni-berlin.de!not-for-mailFrom: xxx xxx <[e-mail]>Newsgroups: x.x.x
Viewing the source in Messenger the line breaks were displayed but not in an
external editor.

Comment 11

[(not reading, please use [e-mail] instead)]

Comment on attachment 174400 [details] [diff] [review]
fix for regression

pieces of this patch are from bug #107776, which also happens to be a=sspitzer
for 1.8b2

Comment 12

[David :Bienvenu]

yes, the line ending problem was the problem.

Comment 13

[David :Bienvenu]

Comment on attachment 174400 [details] [diff] [review]
fix for regression

this is fallout from bug 166111, so if we want that, we'll need this fix as
well.

Comment 14

[Daniel Veditz [:dveditz]]

Not enough components in Core :-( but I need to move this so I can get
thunderbird-blocking flags as well.

Comment 15

[Daniel Veditz [:dveditz]]

If we're going to take this on the stable branches we need to land early in a
release cycle. Moving nomination to 1.0.6

Comment 16

[Asa Dotzler [:asa]]

Comment on attachment 174322 [details] [diff] [review]
proposed fix

1.7.9 has already shipped. unsetting approval request.

Comment 17

[Asa Dotzler [:asa]]

Comment on attachment 174400 [details] [diff] [review]
fix for regression

unsetting approval 1.7.9 request since that release has already shipped.