28209 - File type is not provided in SaveAs dialog

Status: VERIFIED FIXED

(Core Graveyard :: File Handling, defect, P3)

Description

[David Charlap]

Go to your favorite URL.  Save something (the page, an image, whatever).

In all cases, the "Save as type" in the dialog is set to "All Files" and there 
are no other choices.  This results in three problems.

1: You must provide a file extension if you provide a new name - none will be
   automatcally provided.  (See bug 26310)

2: The dialog's list of files doesn't auto-filter to the file type being saved.

3: If any file conversion (for instance, HTML->text or JPG->GIF) is to be
   done, there's no way for the user to request it.  I'm not requesting that
   the ability to do file-type conversion be implemented, only that the dialog
   should provide the ability to select a type so that other code could be
   written to do this conversion.

While Mozilla obviously can't deal with evey kind of file it may have, there 
should be some generic filters for the most common types (like text/plain, 
text/html, image/gif, etc.)  Pulling additional filters from whatever registry 
is used for associating MIME types with applications/plugins would also be 
useful.

As an example of the behavior I'm describing, launch Netscape and select 
File->SaveAs when an HTML URL is displayed.  The dialog gives you three choices 
(HTML Files being the default):
	HTML File (*.htm *.html)
	Plain Text (*.txt)
	All Files (*.*)

When saving a GIF image, Netscape's dialog has two options:
	GIF File (*.gif)
	All Files (*.*)

etc.

I'm not sure if this should be treated as a bug or an enhancement.  IMO, it's a 
bug, but feel free to change the severity if you feel otherwise.

If the XP SaveAs dialog code already supports this, then the bug is with the 
parts of Mozilla that create and open SaveAs dialogs - that code should be 
providing filters to the dialog.  Please reassign as necessary.

Comment 1

[Paul MacQuiddy]

this is an xpapps issue

I imagine we should shoot for at least 4.x compatibility for FCS

sairuh, maybe another test case :-)

Comment 2

[Sean Richardson]

Confirmed with 2000-02-17-08-M14 nightly binary on WinNT, plus dozens of
earlier builds on WinNT and Linux.

Comment 3

[verah (gone)]

Reassigning as per Don

Comment 4

[leger]

Putting on [nsbeta2+][6/01] radar.  This work must be done by 06/01 or we may 
pull this for PR2.

Comment 5

[leger]

Changing from [6/01] to [6/15]

Comment 6

[don]

Move to M19 target milestone.

Comment 7

[Bill Law]

I don't think this is a beta2 blocker.

The only really valuable (IMHO) functio missing is the ability to save html as 
an "ascii rendering" form by choosing "plain text."  But, that function does not 
seem to be readily available in Mozilla so getting it for beta2 is unlikely.

People can live with having to enter a file extension, I should think.  The 
problem here is that download just sucks in general and we must give priority to 
fixing that rather than embellishing the function that doesn't even work 
properly.  Likewise, they'll have to live with typing in *.foo ("manually" 
filter).

Comment 8

[Jim Roskind]

Cleaning up status whiteboard by marking beta2 minus (6/15 has passed)

It sounds like you're already focused on more important stuff, and that is why 
you've put this off for beta3 or later fixing.

Comment 9

[verah (gone)]

Nav triage team: [nsbeta3-]

Comment 10

[Daniel Veditz [:dveditz]]

Adding nsbeta3 keyword to bugs which already have nsbeta3 status markings so 
the queries don't get all screwed up.

Comment 11

[Paul Chen]

nav triate team:

Not going to hold beat1 for this. Marking nsbeta1-

Comment 12

[Paul Chen]

Marking nsbeta1- bugs as future to get off the radar

Comment 13

[Ariel Gonzalez]

Wouldnt it be better for this bug to be a dupe of Bug 31519?
Sure, this one is older, but that other one has more activity and it deals with
the same issues.

Comment 14

[Tomasz Saniawa]

Win32: This bug is only active when Options for Windows Explorer are set to hide
known file types (default) - truncates last file extension like view in
Explorer. If this option is unset - Save dialog behaves correctly.

Comment 15

[Boris Zbarsky [:bzbarsky]]

This is fixed.  The Save As dialog now has the type of the file listed as the
default type.  It was fixed as part of the "save complete page" checkin.

Comment 16

[sairuh (rarely reading bugmail)]

yep. vrfy.