282098 - Accessible focus can get trapped inside of closed popup

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

When a combo box has focus on a menuitem inside of it, but it closes, a new
focus event should be fired to indicate where focus currently is. In addition,
calls to IAccessible::get_accFocus() should not return a hidden child inside of
the popup.

Comment 1

[Aaron Leventhal]

Attachment: When focus is inside popup that becomes hidden, fire focus event for current DOM focus

Comment 2

[Philip K. Warren]

Comment on attachment 174192 [details] [diff] [review]
When focus is inside popup that becomes hidden, fire focus event for current DOM focus

>Index: accessible/src/base/nsRootAccessible.cpp
>===================================================================
>RCS file: /cvsroot/mozilla/accessible/src/base/nsRootAccessible.cpp,v
>retrieving revision 1.108
>diff -p -u -5 -r1.108 nsRootAccessible.cpp
>--- accessible/src/base/nsRootAccessible.cpp	11 Feb 2005 13:18:39 -0000	1.108
>+++ accessible/src/base/nsRootAccessible.cpp	13 Feb 2005 06:21:32 -0000
>@@ -635,10 +670,26 @@ NS_IMETHODIMP nsRootAccessible::HandleEv
>     if (accessNode) {
>       accessNode->GetDOMNode(getter_AddRefs(targetNode));
>       FireAccessibleFocusEvent(accessible, targetNode);
>     }
>   }
>+  else if (eventType.LowerCaseEqualsLiteral("popuphiding")) {
...

>@@ -714,10 +765,26 @@ NS_IMETHODIMP nsRootAccessible::HandleEv
>     accessible->GetFinalState(&stateData.state);
>     stateData.enable = (stateData.state & STATE_EXPANDED) != 0;
>     stateData.state = STATE_EXPANDED;
>     privAcc->FireToolkitEvent(nsIAccessibleEvent::EVENT_STATE_CHANGE, accessible, &stateData);
>   }
>+  else if (eventType.LowerCaseEqualsLiteral("popuphiding")) {
...

The duplication of code here is unfortunate. The platform specific handling
should really go into the atk/msaa directories.

Comment 3

[Aaron Leventhal]

Comment on attachment 174192 [details] [diff] [review]
When focus is inside popup that becomes hidden, fire focus event for current DOM focus

Needed for tight collaboration cycle with screen reader vendor and testers.

Comment 4

[Aaron Leventhal]

Checking in nsRootAccessible.cpp;
/cvsroot/mozilla/accessible/src/base/nsRootAccessible.cpp,v  <-- 
nsRootAccessible.cpp
new revision: 1.109; previous revision: 1.108
done
Checking in nsRootAccessible.h;
/cvsroot/mozilla/accessible/src/base/nsRootAccessible.h,v  <--  nsRootAccessible.h
new revision: 1.45; previous revision: 1.44
done

Comment 5

[Aaron Leventhal]

Checking in nsRootAccessible.cpp;
/cvsroot/mozilla/accessible/src/base/nsRootAccessible.cpp,v  <-- 
nsRootAccessible.cpp
new revision: 1.109; previous revision: 1.108
done
Checking in nsRootAccessible.h;
/cvsroot/mozilla/accessible/src/base/nsRootAccessible.h,v  <--  nsRootAccessible.h
new revision: 1.45; previous revision: 1.44
done

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 174192 [details] [diff] [review]
When focus is inside popup that becomes hidden, fire focus event for current DOM focus

too late for 1.8b1; please land on trunk (which is now open)

Comment 7

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381