282141 - Use system colors pref uses the wrong color for default background

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Christopher Aillon (sabbatical, not receiving bugmail)]

We should use base, not bg.  Patch coming.

Comment 1

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: Patch

Use base, and get rid of an extra assignment of aColor (it gets assigned 0 in
the default: branch of the switch)

Comment 2

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 174243 [details] [diff] [review]
Patch

blizzard says sr=blizzard (looking over my shoulder)

Comment 3

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 174243 [details] [diff] [review]
Patch

Let's get this for 1.8b, and the branches.

Comment 4

[Asa Dotzler [:asa]]

Comment on attachment 174243 [details] [diff] [review]
Patch

a=asa for 1.8b. Will evaluage with other drivers for the branches.

Comment 5

[Christopher Aillon (sabbatical, not receiving bugmail)]

this only affects when the pref is set to "use system colors", which it is not
by default.  I flip this on in my RPMs in rawhide and would like to move it over
to FC3 RPMs, but the pref currently makes top sites such as yahoo.com look quite
bad because of this bug.

Comment 6

[Christopher Aillon (sabbatical, not receiving bugmail)]

Fixed on trunk

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This patch looks wrong to me.  WindowBackground and WindowText should
correspond, which means they should either be bg and fg or base and text.

Comment 8

[Marco Pesenti Gritti]

Good point. I think they should be base and text.

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 174243 [details] [diff] [review]
Patch

This version shouldn't go in for a final release; we'll consider the fixed
version when it's ready.

Comment 10

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: Patch

Against the previous version, for completeness (and for branches? -- too late
for the 1.0.1/1.7.6 set of releases, but for the next ones?)

Comment 11

[Christopher Aillon (sabbatical, not receiving bugmail)]

Checked in the remaining portion of the patch 2005-03-08 13:54.