282200 - xpfe/appshell cleanup

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Brian Ryner (not reading)]

Before starting on bug 21296, I decided to clean up all of the unnecessary crap
in WebShellWindow/XULWindow.

Comment 1

[Brian Ryner (not reading)]

Attachment: patch

The cleanup here is pretty across-the-board, ranging from removing unused
members to removing redundant code to eliminating nsIWebShellWindow entirely.

Comment 2

[Brian Ryner (not reading)]

Attachment: diff -w for easier reviewing

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 174279 [details] [diff] [review]
diff -w for easier reviewing

>Index: xpfe/appshell/public/nsIAppShellService.idl
>-   * @param aShowWindow the window remains invisible if PR_FALSE.
>-   * @param aLoadDefaultPage controls whether the window should try to
>-   *                         load a default content page on its own.

It's worth documenting that the newly-created window will not be visible until
it's manually shown, I think....

sr=bzbarsky with that.	Good to see this cleanup!

Comment 4

[Dan M]

Comment on attachment 174279 [details] [diff] [review]
diff -w for easier reviewing

Wow. So much cruft. By the way I happened to notice you can just get rid of
this local variable, rather than moving it

@@ -359,6 +347,8 @@ nsAppShellService::JustCreateTopWindow(n
       }  
     }

+  PRBool intrinsicallySized = PR_FALSE;
+

Comment 5

[Brian Ryner (not reading)]

checked in.