Closed
Bug 282265
Opened 19 years ago
Closed 19 years ago
tree.view not directly available after it is set hidden=false, when it was first hidden=true
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla1.8beta1
People
(Reporter: martijn.martijn, Assigned: bzbarsky)
References
Details
(Keywords: testcase)
Attachments
(2 files)
1.31 KB,
application/vnd.mozilla.xul+xml
|
Details | |
1.86 KB,
patch
|
mconnor
:
review+
neil
:
superreview+
asa
:
approval1.8b+
|
Details | Diff | Splinter Review |
This issue caused bug 260951. I'm not sure if it is a bug, feel free to resolve it INVALID, if you think so. I'll attach a testcase. When you click for the first time on the "alert(tree.view)" button, it shows 'null'. But in older builds (before 2004-08-10) it showed '[object XULTreeBuilder]' already for the first time. This worked in Firefox build 2004-08-09 06:48am. But it doesn't work anymore in Firefox build 2004-08-10 06:49am. http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2004-08-09+06%3A48%3A00&maxdate=2004-08-10+06%3A49%3A00&cvsroot=%2Fcvsroot I think this has changed because of the fix of bug 230170.
Reporter | ||
Comment 1•19 years ago
|
||
Assignee | ||
Comment 2•19 years ago
|
||
Hmm.. the patch for bug 260951 looks like a nasty hack that could use backing out... ;) I think the right fix is to fix nsBoxObject::GetFrame to flush out frame construction when it's called. Now the question is, how often is it called from inside frame code?
Assignee | ||
Comment 3•19 years ago
|
||
Attachment #174334 -
Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #174334 -
Flags: review?(mconnor)
Updated•19 years ago
|
Attachment #174334 -
Flags: superreview?(neil.parkwaycc.co.uk) → superreview+
Comment 4•19 years ago
|
||
Comment on attachment 174334 [details] [diff] [review] Patch, should be *cough* this was my master plan all along.... Thanks. :)
Attachment #174334 -
Flags: review?(mconnor) → review+
Assignee | ||
Comment 5•19 years ago
|
||
Comment on attachment 174334 [details] [diff] [review] Patch, should be Could this be approved for 1.8b? This is fallout from back in the summer, and affects all box object users... The patch should be pretty safe -- I've checked our frame code to make sure this function is not called from inside frame implementations...
Attachment #174334 -
Flags: approval1.8b?
Comment 6•19 years ago
|
||
Comment on attachment 174334 [details] [diff] [review] Patch, should be a=asa for 1.8b
Attachment #174334 -
Flags: approval1.8b? → approval1.8b+
Assignee | ||
Updated•19 years ago
|
Assignee: nobody → bzbarsky
OS: Windows XP → All
Hardware: PC → All
Target Milestone: --- → mozilla1.8beta1
Assignee | ||
Comment 7•19 years ago
|
||
Fixed for 1.8b1.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Comment 8•19 years ago
|
||
Unfortunately, this does not appear to fix the original issue from bug 260951.
Assignee | ||
Comment 9•19 years ago
|
||
Ah, indeed. The flush is ignored, since we're inside frame construction... :( The change in bug 282359 will help with that; if that doesn't land soon, I'll undo the JS changes in this bug.
Depends on: 282359
You need to log in
before you can comment on or make changes to this bug.
Description
•