282275 - remove NS_NOTREACHED in ReadSegments implementations

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

it is not a mistake to call ReadSegments on a stream that does not support it.
callers may handle NS_ERROR_NOT_IMPLEMENTED gracefully and fall back to Read.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in modules/libjar/nsJARChannel.cpp;
/cvsroot/mozilla/modules/libjar/nsJARChannel.cpp,v  <--  nsJARChannel.cpp
new revision: 1.114; previous revision: 1.113
done
Checking in netwerk/base/src/nsDirectoryIndexStream.cpp;
/cvsroot/mozilla/netwerk/base/src/nsDirectoryIndexStream.cpp,v  <-- 
nsDirectoryIndexStream.cpp
new revision: 1.34; previous revision: 1.33
done
Checking in netwerk/base/src/nsFileStreams.cpp;
/cvsroot/mozilla/netwerk/base/src/nsFileStreams.cpp,v  <--  nsFileStreams.cpp
new revision: 1.72; previous revision: 1.71
done
Checking in netwerk/cache/src/nsCacheEntryDescriptor.cpp;
/cvsroot/mozilla/netwerk/cache/src/nsCacheEntryDescriptor.cpp,v  <-- 
nsCacheEntryDescriptor.cpp
new revision: 1.58; previous revision: 1.57
done
Checking in netwerk/cache/src/nsDiskCacheStreams.cpp;
/cvsroot/mozilla/netwerk/cache/src/nsDiskCacheStreams.cpp,v  <-- 
nsDiskCacheStreams.cpp
new revision: 1.16; previous revision: 1.15
done