Closed
Bug 282438
Opened 20 years ago
Closed 20 years ago
Improperly nested menupopupend events breaks screen reader support
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: aaronlev, Assigned: aaronlev)
Details
(Keywords: access, regression)
Attachments
(1 file, 2 obsolete files)
|
5.02 KB,
patch
|
bryner
:
review+
neil
:
superreview+
mkaply
:
approval1.8b-
|
Details | Diff | Splinter Review |
When autocomplete widgets open we are firing menupopupstart but no menupopupend.
This causes the screen reader to think it is still in a menu when it isn't,
completely breaking accessibility from that point on.
This is a regression caused by the fix for bug 281568
|
Assignee | |
Comment 1•20 years ago
|
||
Attachment #174451 -
Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #174451 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Comment 2•20 years ago
|
||
|
|
Assignee | |
Updated•20 years ago
|
Attachment #174451 -
Attachment is obsolete: true
Attachment #174481 -
Flags: superreview?(neil.parkwaycc.co.uk)
|
|
Assignee | |
Updated•20 years ago
|
Attachment #174451 -
Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #174451 -
Flags: review?(bzbarsky)
|
||
Comment 3•20 years ago
|
||
Comment on attachment 174481 [details] [diff] [review]
Fire in ActivatePopup()
This looks right apart from a space before the ? and a missing declaration of
mIsOpen.
Could you file a bug on passing mIsOpen to SyncViewWithFrame to avoid having to
use the menutobedisplayed attribute?
|
|
Assignee | |
Comment 4•20 years ago
|
||
Attachment #174481 -
Attachment is obsolete: true
Attachment #174491 -
Flags: superreview?(neil.parkwaycc.co.uk)
|
|
Assignee | |
Updated•20 years ago
|
Attachment #174481 -
Flags: superreview?(neil.parkwaycc.co.uk)
|
|
Assignee | |
Updated•20 years ago
|
Attachment #174491 -
Flags: review?(bryner)
|
|
||
Updated•20 years ago
|
Attachment #174491 -
Flags: superreview?(neil.parkwaycc.co.uk) → superreview+
|
||
Updated•20 years ago
|
Attachment #174491 -
Flags: review?(bryner) → review+
|
|
Assignee | |
Comment 5•20 years ago
|
||
Comment on attachment 174491 [details] [diff] [review]
Fix whitespace, add forgotton nsPopupSetFrame.h with mIsOpen declaration
Needed for tight testing cycle with screen reader developer and testers.
Attachment #174491 -
Flags: approval1.8b?
|
|
Assignee | |
Updated•20 years ago
|
Severity: normal → blocker
|
||
Comment 6•20 years ago
|
||
Comment on attachment 174491 [details] [diff] [review]
Fix whitespace, add forgotton nsPopupSetFrame.h with mIsOpen declaration
a=mkaply.
Attachment #174491 -
Flags: approval1.8b? → approval1.8b+
|
|
||
Comment 7•20 years ago
|
||
Comment on attachment 174491 [details] [diff] [review]
Fix whitespace, add forgotton nsPopupSetFrame.h with mIsOpen declaration
too late
Attachment #174491 -
Flags: approval1.8b+ → approval1.8b-
|
|
Assignee | |
Comment 8•20 years ago
|
||
/cvsroot/mozilla/layout/xul/base/src/nsBoxFrame.cpp,v <-- nsBoxFrame.cpp
new revision: 1.268; previous revision: 1.267
done
Checking in layout/xul/base/src/nsBoxFrame.h;
/cvsroot/mozilla/layout/xul/base/src/nsBoxFrame.h,v <-- nsBoxFrame.h
new revision: 1.92; previous revision: 1.91
done
Checking in layout/xul/base/src/nsPopupSetFrame.h;
/cvsroot/mozilla/layout/xul/base/src/nsPopupSetFrame.h,v <-- nsPopupSetFrame.h
new revision: 1.42; previous revision: 1.41
done
Checking in layout/xul/base/src/nsPopupSetFrame.cpp;
/cvsroot/mozilla/layout/xul/base/src/nsPopupSetFrame.cpp,v <-- nsPopupSetFrame.cpp
new revision: 1.120; previous revision: 1.119
done
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•