282495 - The /list command fails

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[Jim]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

Connected to ircd version 2.10.3p1 on OpenBSD 3.6.  Submitting the /list command
returns nothing even though 30+ channels exist and are visible via /list on
other clients.  Chatzilla 0.9.66 did not have this problem.  Confirmed this
behavior by upgrading a working 0.9.66 client to 0.9.67 and submitting /list
command.

Reproducible: Always

Steps to Reproduce:
1. connect to an irc server and submit /list command
2. upgrade 0.9.67
3. connect to an irc server and submit /list command again

Actual Results:  
/list no longer returns and results.  Nor does the "Join Channel" dialogue box.

Expected Results:  
list all channels on the irc server

Comment 1

[Jim]

Worked backwards from 0.9.67 testing all revisions to see where the /list
command stopped working.  0.9.66e, d, c, b, and a all had the same bug. 
However, after reinstalling 0.9.66, the /list command worked as expected.  So
something changed between 0.9.66 and 0.9.66a that broke the /list command for me.

Comment 2

[James Ross]

I see no way to debug this without a server to connect to and debug on.

Comment 3

[Samuel Sieb]

Using about:config, set the following pref to true:
javascript.options.showInConsole

Try the /list again and see if there are any chatzilla-related errors in the JS
console.

Comment 4

[James Ross]

Ok, thanks to the dump of the _list object I've worked it out.

See
http://lxr.mozilla.org/mozilla/source/extensions/irc/xul/content/handlers.js#1248

That checks for _list and _list.done to exist.
http://lxr.mozilla.org/mozilla/source/extensions/irc/xul/content/handlers.js#1116
sets done when starting, thus for servers that don't send a LIST header you get
this problem (apparently almost no servers do this).

Working on a better check...

Comment 5

[James Ross]

Attachment: Check for "lastLength" instead of "done"

This also tweaks some other code to not bother checking if some properties
exist, as the four (string, regexp, done and count) are gurenteed to always be
set on _list.

Comment 6

[James Ross]

/me slaps BugZilla

Comment 7

[James Ross]

Checked in --> FIXED.

In approximately 12 minutes a build with this fix will be available from:
 http://twpol.dyndns.org/mozilla/chatzilla/nightly/

Comment 8

[Jim]

FIXED!!!!  Thanks!!!!

I confirmed both the /list command on the server view as well as the "join
channel" dialogue box.  Both work correctly.

Comment 9

[Jim]

I should have mentioned that I tested
http://twpol.dyndns.org/mozilla/chatzilla/nightly/xpi/chatzilla-0.9.67-2005021921.xpi

Thanks again.