Closed
Bug 282643
Opened 20 years ago
Closed 19 years ago
Rename two of three buf local variables in nsHttpChannel::SetupTransaction
Categories
(Core :: Networking: HTTP, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timeless)
Details
Attachments
(1 obsolete file)
Debugging this function is not aided by the fact that there are three variables (two of the same kind!). Unless someone wants to consilidate them (which risks confusing thinigs given one of the buffers is assigned by reference to another object which someone might reuse later, i'd like to rename two of the buffers to describe the strings they actually hold.
Attachment #174623 -
Flags: superreview?(darin)
Attachment #174623 -
Flags: review?(darin)
|
||
Comment 2•20 years ago
|
||
Comment on attachment 174623 [details] [diff] [review] give buffer objects meaningful names it was probably me who added these variables... sorry
Attachment #174623 -
Flags: review?(darin) → review+
|
||
Comment 3•20 years ago
|
||
Comment on attachment 174623 [details] [diff] [review] give buffer objects meaningful names I like |buf| as the name of a temporary buffer, but sure whatever.
Attachment #174623 -
Flags: superreview?(darin) → superreview+
Comment on attachment 174623 [details] [diff] [review] give buffer objects meaningful names mozilla/netwerk/protocol/http/src/nsHttpChannel.cpp 1.241
Attachment #174623 -
Attachment is obsolete: true
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•