282700 - allocation/free mismatch of gParts and gVariants in nsMathMLChar.cpp

Status: RESOLVED FIXED

(Core :: MathML, defect)

Description

[David Gardiner]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

PREfast reports the following warnings when analysing this file:

nsmathmlchar.cpp(1172) : warning 283: Allocation/free mismatch:
'?gParts@nsGlyphTableList@@2PAHA' is allocated with array new [], but deleted
with scalar delete (see allocation at line 1163 of
d:\mozilla\mozilla\layout\mathml\base\src\nsmathmlchar.cpp).
problem occurs in function 'InitGlobals'

nsmathmlchar.cpp(1173) : warning 283: Allocation/free mismatch:
'?gVariants@nsGlyphTableList@@2PAHA' is allocated with array new [], but deleted
with scalar delete (see allocation at line 1164 of
d:\mozilla\mozilla\layout\mathml\base\src\nsmathmlchar.cpp).
problem occurs in function 'InitGlobals'

Reproducible: Always

Steps to Reproduce:

Comment 1

[David Gardiner]

Attachment: use array delete for stuff that was array new'd.

Comment 2

[rbs]

Comment on attachment 174671 [details] [diff] [review]
use array delete for stuff that was array new'd.

r+sr=rbs

Comment 3

[Boris Zbarsky [:bzbarsky]]

rbs, are you going to check this in, or should I?

Comment 4

[rbs]

over to you, bz.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Checked in for 1.8b2.  Thanks for the patch, David!