282713 - Hiding last (as in the only) tab causes spewage

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[Tuukka Tolvanen (sp3000)]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b) Gecko/20050213 Firefox/1.0+
Build Identifier: Chatzilla 0.9.67 [Firefox 1.0+/20050213]

Hiding last tab causes
	[ERROR]	Internal error dispatching command “hide-view”.
	[ERROR]	TypeError: client.viewsArray[i] has no properties @
                <chrome://chatzilla/content/commands.js> 1448

'Hide Tab' is disabled in the context menu when only one tab is open, but
middle-clicking a tab "works".

Reproducible: Always

Steps to Reproduce:
1. Middle click on each chatzilla tab.

Actual Results:  
The hidden view popped back up with an exception.

Expected Results:  
Nothing, perhaps with a message.

Comment 1

[Tuukka Tolvanen (sp3000)]

Attachment: patch1

Add check and associared error message against client.viewsArray.length < 2 to
cmdHideView, as in cmdDeleteView.

Comment 2

[James Ross]

Comment on attachment 174686 [details] [diff] [review]
patch1

r=[e-mail]

Comment 3

[James Ross]

Checked in --> FIXED.

In approximately 55 minutes a build with this fix will be available from:
  http://twpol.dyndns.org/mozilla/chatzilla/nightly/