282777 - Implement index() xpath function

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[aaronr]

Now that setIndex patch is in, I can implement index() xpath function.

Comment 1

[aaronr]

Attachment: first attempt

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 174741 [details] [diff] [review]
first attempt

>+NS_IMETHODIMP
>+nsXFormsUtilityService::GetRepeatIndex(nsIDOMNode *aRepeat, PRUint32 *aIndex)
>+{
>+  NS_ENSURE_ARG_POINTER(aRepeat);
>+  NS_ENSURE_ARG_POINTER(aIndex);

Nit: There should be no need to check that the 'returnpointer' (in this case
aIndex) is nonnull. If you really want to be sure add an assertion instead.

r=me except on the nsXFormsUtilityService.cpp part that I don't really know
enough xforms for.

Comment 3

[aaronr]

Allan, can you give a second review, please?  I will fix Jonas' nit.

Comment 4

[Allan Beaufour]

Comment on attachment 174741 [details] [diff] [review]
first attempt

I'll leave the transformiix-part in sicking's hands :)

>+nsXFormsUtilityService::GetRepeatIndex(nsIDOMNode *aRepeat, PRUint32 *aIndex)
>+{
>+  NS_ENSURE_ARG_POINTER(aRepeat);
>+  NS_ENSURE_ARG_POINTER(aIndex);
>+  *aIndex = 0;
>+
>+  nsCOMPtr<nsIXFormsRepeatElement> repeatEle = do_QueryInterface(aRepeat);
>+  NS_ENSURE_TRUE(repeatEle, NS_ERROR_NULL_POINTER);
>+
>+  return repeatEle->GetIndex(aIndex);
>+}

Almost the same comment from me. No need to check aRepeat either, as you check
it after the QI. aIndex will be checked by GetIndex(), and set if it returns
succesfully, so I guess you can just do:
>+nsXFormsUtilityService::GetRepeatIndex(nsIDOMNode *aRepeat, PRUint32 *aIndex)
>+{
>+  nsCOMPtr<nsIXFormsRepeatElement> repeatEle = do_QueryInterface(aRepeat);
>+  NS_ENSURE_STATE(repeatEle);
>+
>+  return repeatEle->GetIndex(aIndex);
>+}

With that, r=me.

Comment 5

[aaronr]

Attachment: final patch

patch that takes in comments from Allan and Jonas.  Peterv said that he didn't
need to sr as long as Jonas reviewed it.

Comment 6

[Doron Rosenberg (IBM)]

checked in.

Comment 7

[Doron Rosenberg (IBM)]

really marking fixed.