282800 - Potential NULL argument 3 to 'memset' in nsUnicodeToJamoTTF.cpp

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[David Gardiner]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

PREfast static code analysis of nsUnicodeToJamoTTF.cpp gives the following warning:

nsunicodetojamottf.cpp(327) : warning 309: Potential NULL argument 3 to 'memset'.
problem occurs in function 'nsUnicodeToJamoTTF::Reset'

This line is currently:

memset(mJamos, sizeof(mJamosStatic), 0); 

I wonder if the arguments for the memset are the wrong way around?

Should this actually be:

memset(mJamos, 0, sizeof(mJamosStatic)); 

?

-dave

Reproducible: Always

Steps to Reproduce:

Comment 1

[Jungshik Shin]

Taking. Thanks for catching it. You're right that the second argument should be 0. 

Comment 2

[Jungshik Shin]

Attachment: patch(1-liner)

This is a simple one-liner that does the right thing and is safe for branches.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 174763 [details] [diff] [review]
patch(1-liner)

sr=bzbarsky

Comment 4

[Daniel Veditz [:dveditz]]

Comment on attachment 174763 [details] [diff] [review]
patch(1-liner)

r=dveditz
a=dveditz for the 1.7 and aviary1.0.1 branches

The aviary1.0.1 branch is closing at midnight PST (may in fact have until 2am).
Get it in tonight or it misses the bus.

Comment 5

[Jungshik Shin]

Thanks for r/sr/a. landed in branches (1.7.x and av 1.0.1)and trunk