Closed
Bug 283092
Opened 21 years ago
Closed 21 years ago
<svg:image> changes for OS-X
Categories
(Core :: SVG, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: tor, Assigned: tor)
References
Details
Attachments
(1 file, 1 obsolete file)
|
5.14 KB,
patch
|
jhpedemonte
:
review+
|
Details | Diff | Splinter Review |
Channel ordering and bytes per pixel are different on OS-X.
Attachment #175081 -
Attachment is obsolete: true
Attachment #175323 -
Flags: review?(jhpedemonte)
|
||
Comment 3•21 years ago
|
||
Comment on attachment 175323 [details] [diff] [review]
more channel ordering
+#ifdef XP_MACOSX
+ // pixels on os-x have a lead byte we don't care about - shift
+ // our pointer down one so we can use the rest of the code as-is
+ rgb++;
#endif
Add a comment that the lead byte belongs to the alpha information (or garbage
if the image has no alpha info).
-#ifdef XP_WIN
+#ifdef XP_MACOSX
+ *target++ = 255;
+#endif
+#ifndef REVERSE_CHANNELS
Add a comment for why you need to do this for mac first, and for every other
platform later.
Otherwise, looks great.
Attachment #175323 -
Flags: review?(jhpedemonte) → review+
Checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•