283145 - mail_help doesn't validate as XHTML 1.1

Status: RESOLVED FIXED

(SeaMonkey :: Help Documentation, defect)

Description

[Giacomo Magnini]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040922
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040922

mail_help has a XHTML 1.1 doctype, but it doesn't validate since it uses some
really old html structs. This bug is just for cleaning up the tags, nothing else.

Reproducible: Always

Steps to Reproduce:

Comment 1

[Giacomo Magnini]

Attachment: With these changes, mail_help does validate on WDG (except for brand.dtd, as always)

Comment 2

[Stefan [:stefanh]]

--> Giacomo

Hmm, don't forget to ask for review ;)

Comment 3

[Ian Neal]

Comment on attachment 175129 [details] [diff] [review]
With these changes, mail_help does validate on WDG (except for brand.dtd, as always)

You have put in the ' to ' changes as well - all those changes should be
in the appropiate bug not this one.

Comment 4

[Giacomo Magnini]

Attachment: Another lesson learned: don't count on gedit Undo button... Sorry Ian... :( (Checked in)

I'll be out of town till next week, so the rest of the patches will have to
wait.

Comment 5

[Ian Neal]

Comment on attachment 175400 [details] [diff] [review]
Another lesson learned: don't count on gedit Undo button... Sorry Ian... :(
(Checked in)

Checking in mail_help.xhtml;
/cvsroot/mozilla/extensions/help/resources/locale/en-US/mail_help.xhtml,v  <-- 
mail_help.xhtml
new revision: 1.55; previous revision: 1.54
done

Comment 6

[Stefan [:stefanh]]

Nit: I think those two changes below made the images and the title text not
lining up correctly:

----------------------------------------------------------------------------
 <table>
 <tr>
-<td colspan="2"><img src="images/mail_read_column.png" hspace="81"
-vspace="0" /></td>
+<td colspan="2"><img src="images/mail_read_column.png" alt="" /></td>
 </tr>
 
 <tr>
-<td width="80"></td>
+<td style="width: 80px;"></td>
 <td><strong>Read column</strong></td>
 </tr>
 </table>
----------------------------------------------------------------------------
 <table>
 <tr>
-<td colspan="2"><img src="images/mail_flag_column.png" hspace="81"
-vspace="0" /></td>
+<td colspan="2"><img src="images/mail_flag_column.png" alt="" /></td>
 </tr>
 
 <tr>
-<td width="80"></td>
+<td style="width: 80px;"></td>
 <td><strong>Flag column</strong></td>
 </tr>
 </table>
----------------------------------------------------------------------------