283356 - nsPSPrinters.cpp compile error: implicit declaration of function `int strcasecmp(...)'

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[Max Feil - mfeil%qnx.com]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0)
Build Identifier: 

Source file gfx/src/psshared/nsPSPrinters.cpp has a compile error under QNX:
nsPSPrinters.cpp: In method `PRBool nsPSPrinterList::Enabled()':
nsPSPrinters.cpp:83: implicit declaration of function `int strcasecmp(...)'

I think the strcasecmp() should be changed to PL_strcasecmp(), since the 
header "plstr.h" is already being included and the PL_strtok_r() function is 
already being used elsewhere in the source file.

Reproducible: Always

Steps to Reproduce:
1. Install QNX 6.3.0 operating system
2. cvs co mozilla/client.mk
3. make -f client.mk checkout
4. ./configure
5. make

Actual Results:  
Compile error in nsPSPrinters.cpp

Expected Results:  
No compile error in nsPSPrinters.cpp

Comment 1

[Kenneth Herron]

Accepting. Max, it'd be great if you could submit a patch for this; otherwise
I'll try to get to it in the next week or two.

Comment 2

[Max Feil - mfeil%qnx.com]

Attachment: Proposed patch

Comment 3

[Andreas Lange]

Comment on attachment 175362 [details] [diff] [review]
Proposed patch

Simple and good fix, assuming it just fell of the radar and setting review flag
to get it back there.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Checking in nsPSPrinters.cpp;
/cvsroot/mozilla/gfx/src/psshared/nsPSPrinters.cpp,v  <--  nsPSPrinters.cpp
new revision: 1.4; previous revision: 1.3
done