Closed
Bug 283509
Opened 20 years ago
Closed 20 years ago
OOM crasher [@ mozEnglishWordUtils::FromRootForm]
Categories
(Core :: Spelling checker, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: timeless, Assigned: dewildt)
References
()
Details
(Keywords: crash)
Crash Data
Attachments
(1 obsolete file)
note that cleanup for this case needs to properly release the partially
constructed array.
|
Assignee | |
Comment 1•20 years ago
|
||
The array is not released in other error situations. (For example, if result of
rv is not NS_OK inside the switch, is that ok?)
Who should do sr?
|
|
Assignee | |
Updated•20 years ago
|
Attachment #176063 -
Attachment description: This patch cleanup the allocated array if the loop is ended with an error → This patch cleanup the array inside the for loop and returns an error
Attachment #176063 -
Flags: superreview?(mscott)
Attachment #176063 -
Flags: review?(timeless)
Attachment #176063 -
Flags: review+
|
||
Updated•20 years ago
|
Attachment #176063 -
Flags: superreview?(mscott) → superreview+
Attachment #176063 -
Flags: approval1.8b3?
|
||
Comment 2•20 years ago
|
||
Comment on attachment 176063 [details] [diff] [review]
This patch cleanup the array inside the for loop and returns an error
a=chofmann
Attachment #176063 -
Flags: approval1.8b3? → approval1.8b3+
Comment on attachment 176063 [details] [diff] [review]
This patch cleanup the array inside the for loop and returns an error
mozilla/extensions/spellcheck/src/mozEnglishWordUtils.cpp 1.8
Attachment #176063 -
Attachment is obsolete: true
|
||
Comment 4•20 years ago
|
||
Daniel: Anything left here or can this bug be resolved as FIXED?
|
||
Comment 5•20 years ago
|
||
This landed, marking FIXED.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
|
||
Comment 6•20 years ago
|
||
"Verified" FIXED by checking to make sure this landed in LXR. (I checked
Talkback reports, too, of course, but as this was a precautionary fix, it wasn't
too useful.)
Status: RESOLVED → VERIFIED
|
||
Updated•14 years ago
|
Crash Signature: [@ mozEnglishWordUtils::FromRootForm]
You need to log in
before you can comment on or make changes to this bug.
Description
•