Closed
Bug 283533
Opened 20 years ago
Closed 20 years ago
OOM crash [@ XPCIDispatchClassInfo::GetInterfaces]
Categories
(Core :: XPConnect, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: bastiaan)
References
()
Details
(Keywords: crash)
Crash Data
Attachments
(1 file, 1 obsolete file)
|
1.17 KB,
patch
|
shaver
:
review+
shaver
:
superreview+
benjamin
:
approval1.8b3+
|
Details | Diff | Splinter Review |
note that cleanup for this case needs to properly release the partially
constructed array.
|
Assignee | |
Comment 2•20 years ago
|
||
|
|
Assignee | |
Updated•20 years ago
|
Attachment #187845 -
Flags: superreview?(shaver)
Attachment #187845 -
Flags: review?(shaver)
|
||
Comment 3•20 years ago
|
||
Should we set *count to zero on failure? Or since we're returning an error all
bets are off on out parameters?
I'll repeat the usual style nit about removing spaces in things like "if ("
which.
|
|
Assignee | |
Comment 4•20 years ago
|
||
Assignee: dbradley → b.jacques
Attachment #187845 -
Attachment is obsolete: true
Attachment #187851 -
Flags: superreview?(shaver)
Attachment #187851 -
Flags: review?(dbradley)
|
|
Assignee | |
Updated•20 years ago
|
Attachment #187845 -
Flags: superreview?(shaver)
Attachment #187845 -
Flags: review?(shaver)
|
||
Comment 5•20 years ago
|
||
Comment on attachment 187851 [details] [diff] [review]
address comments
r+sr=shaver
Attachment #187851 -
Flags: superreview?(shaver)
Attachment #187851 -
Flags: superreview+
Attachment #187851 -
Flags: review?(dbradley)
Attachment #187851 -
Flags: review+
|
|
Assignee | |
Updated•20 years ago
|
Attachment #187851 -
Flags: approval1.8b3?
|
||
Comment 6•20 years ago
|
||
Comment on attachment 187851 [details] [diff] [review]
address comments
a=bsmedberg, please land expeditiously
Attachment #187851 -
Flags: approval1.8b3? → approval1.8b3+
|
|
||
Comment 7•20 years ago
|
||
Be good to include dbradley, nominal module owner.
/be
|
|
Assignee | |
Comment 8•20 years ago
|
||
Checked in by timeless (2005-07-06 10:47).
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
||
Updated•14 years ago
|
Crash Signature: [@ XPCIDispatchClassInfo::GetInterfaces]
You need to log in
before you can comment on or make changes to this bug.
Description
•