Closed
Bug 283534
Opened 20 years ago
Closed 20 years ago
OOM crash [@ xpcarraytest]
Categories
(Core :: XPConnect, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: bastiaan)
References
()
Details
(Keywords: crash)
Crash Data
Attachments
(1 file, 1 obsolete file)
|
1.20 KB,
patch
|
shaver
:
review+
shaver
:
superreview+
benjamin
:
approval1.8b3+
|
Details | Diff | Splinter Review |
note that cleanup for some cases need to properly release partially
constructed arrays.
|
Assignee | |
Comment 1•20 years ago
|
||
Assignee: dbradley → b.jacques
Status: NEW → ASSIGNED
Comment on attachment 187656 [details] [diff] [review]
fix
> *uuid = (nsIID*) nsMemory::Clone(&NS_GET_IID(nsIXPCTestArray),
> sizeof(nsIID));
>
> nsISupports** outArray = (nsISupports**)
> nsMemory::Alloc(2 * sizeof(nsISupports*));
>+ NS_ENSURE_TRUE(outArray, NS_ERROR_OUT_OF_MEMORY);
i think you want to release *uuid (and also oom check it)
|
|
Assignee | |
Comment 3•20 years ago
|
||
Attachment #187656 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•20 years ago
|
Attachment #187778 -
Flags: superreview?(shaver)
Attachment #187778 -
Flags: review?(dbradley)
|
||
Comment 4•20 years ago
|
||
Comment on attachment 187778 [details] [diff] [review]
better fix
r+sr=shaver
Attachment #187778 -
Flags: superreview?(shaver)
Attachment #187778 -
Flags: superreview+
Attachment #187778 -
Flags: review?(dbradley)
Attachment #187778 -
Flags: review+
|
|
Assignee | |
Updated•20 years ago
|
Attachment #187778 -
Flags: approval1.8b3?
|
||
Comment 5•20 years ago
|
||
Comment on attachment 187778 [details] [diff] [review]
better fix
a=bsmedberg for checkin on 6/30 only
Attachment #187778 -
Flags: approval1.8b3? → approval1.8b3+
|
|
Assignee | |
Comment 6•20 years ago
|
||
Checked in by timeless (2005-06-30 13:37).
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
||
Updated•14 years ago
|
Crash Signature: [@ xpcarraytest]
You need to log in
before you can comment on or make changes to this bug.
Description
•