Closed
Bug 283540
Opened 19 years ago
Closed 19 years ago
OOM mlk [@ NS_NewPluginPostDataStream]
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: jlurz24)
References
()
Details
(Keywords: memory-leak)
Attachments
(2 obsolete files)
buf will be leaked if sis can't be created
delete the buffer, rv will get returned at the end of the function
Comment on attachment 178904 [details] [diff] [review] nsIPluginHostPatch_v1.txt you only want to free buf if it isn't data.
Attachment #178904 -
Flags: review-
yeah, that would have been crashy.
Attachment #178904 -
Attachment is obsolete: true
Comment on attachment 179004 [details] [diff] [review] nsIPluginHostPatch_v2.txt there should be a space between if and ( per the file's style. please make sure the person who commits this includes it.
Attachment #179004 -
Flags: superreview?(jst)
Attachment #179004 -
Flags: review+
|
||
Comment 5•19 years ago
|
||
Comment on attachment 179004 [details] [diff] [review] nsIPluginHostPatch_v2.txt sr=jst
Attachment #179004 -
Flags: superreview?(jst) → superreview+
Comment on attachment 179004 [details] [diff] [review] nsIPluginHostPatch_v2.txt mozilla/modules/plugin/base/public/nsIPluginHost.idl 1.4
Attachment #179004 -
Attachment is obsolete: true
|
||
Comment 7•19 years ago
|
||
I'm assuming attachment 179004 [details] [diff] [review] means the end of this bug. FIXED.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
||
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•