283576 - DBID_to_real_or_loginname is dead code

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Max Kanat-Alexander]

Nothing uses DBID_to_real_or_loginname.

It should go. It's a silly function, anyway -- almost identical functionality is
provided by Bugzilla::User. :-)

Comment 1

[Max Kanat-Alexander]

Attachment: Really Simple Patch: Remove the Function

This is the simplest patch to review, ever:

1) Grep, notice the function is never called
2) Look at the patch
3) review+

dead code, dead code, what'cha gonna do...

Comment 2

[Marc Schumann [:Wurblzap]]

Comment on attachment 175531 [details] [diff] [review]
Really Simple Patch: Remove the Function

Yes.

I'd shout "die, die, die" now, but the code is *already* dead :)

Comment 3

[Max Kanat-Alexander]

Checking in globals.pl;
/cvsroot/mozilla/webtools/bugzilla/globals.pl,v  <--  globals.pl
new revision: 1.309; previous revision: 1.308
done