Closed Bug 283698 Opened 20 years ago Closed 20 years ago

[FIX]potential inconsistency if a binding is attached while executing a binding destructor

Categories

(Core :: XBL, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla1.8beta2

People

(Reporter: bryner, Assigned: bzbarsky)

Details

Attachments

(1 file)

Spun off from bug 194834: we enumerate the binding manager's binding table to fire binding detached methods (destructors). This read-locks the binding table, which means if a destructor synchronously attaches a binding, it won't be entered into the binding table.
Attached patch Proposed patchSplinter Review
bryner, what do you think?
Attachment #175628 - Flags: superreview?(bryner)
Attachment #175628 - Flags: review?(bryner)
Priority: -- → P2
Summary: potential inconsistency if a binding is attached while executing a binding destructor → [FIX]potential inconsistency if a binding is attached while executing a binding destructor
Target Milestone: --- → mozilla1.8beta2
Comment on attachment 175628 [details] [diff] [review] Proposed patch Yep, this is exactly what I had in mind. Thanks.
Attachment #175628 - Flags: superreview?(bryner)
Attachment #175628 - Flags: superreview+
Attachment #175628 - Flags: review?(bryner)
Attachment #175628 - Flags: review+
Fixed.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: