283827 - When turn on IME and switch applications before fix characters, location bar doesn't accept any more character

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Mac, defect)

Description

[Katsuhiro MIHARA]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050225
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050225

Original report:
http://bugzilla.mozilla.gr.jp/show_bug.cgi?id=4135

User can turn on IME even on location bar.
When user switch applications before fix
characters, location bar doesn't accept
any more characters.

Workaround is only close that window of
Mozilla Suite and reopen another window.


Reproducible: Always

Steps to Reproduce:
1. turn on IME on location bar
2. enter characters on location bar
3. translate characters, but doesn't fix
4. switch applications to other
5. switch applications to Mozilla Suite
6. enter characters on location bar
   (doesn't matter IME is on or off)
Actual Results:  
Location bar doesn't accept any more characters.

Expected Results:  
Location bar should accept more characters.

Comment 1

[Katsuhiro MIHARA]

Attachment: patch (nsMacEventtHandler)

Call FixTSMDocument() before deactivate window.

Ideally, we doesn't need to call FixTSMDocument(),
http://developer.apple.com/documentation/Carbon/Reference/Text_Services_Manager/tsm_refchap/function_group_2.html#//apple_ref/doc/uid/TP30000174/F01518

but Mozilla Suite can't handle next event correctly.

Comment 2

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 175650 [details] [diff] [review]
patch (nsMacEventtHandler)

r=pink

are there any other places we should do this?

Comment 3

[Katsuhiro MIHARA]

I don't find any other places.

I found a place that fix this bug, and just did this.

Comment 4

[Jungshik Shin]

Comment on attachment 175650 [details] [diff] [review]
patch (nsMacEventtHandler)

peterv, would you sr this assuming the old sense of 'sr' still holds? sfraser
is on vacation and you may be the only active superreviewer with  some Mac
connection....
And, it'd be nice of you to take a look at bug 158859 as well.

Comment 5

[Katsuhiro MIHARA]

Please introduce someone who can commit a patch.
I don't have a CVS account.

Comment 6

[timeless]

Comment on attachment 175650 [details] [diff] [review]
patch (nsMacEventtHandler)

the tree is currently frozen, so this patch would need approval before it could
be committed. the change is small and localized.

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 175650 [details] [diff] [review]
patch (nsMacEventtHandler)

a=asa

Comment 8

[timeless]

Comment on attachment 175650 [details] [diff] [review]
patch (nsMacEventtHandler)

mozilla/widget/src/mac/nsMacEventHandler.cpp	1.172

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

-> FIXED