283840 - "Select User Profile" dialog is broken after using "Custom" in installer

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect)

Description

[Mats Palmgren (inactive)]

"Select User Profile" dialog is broken after using "Custom" in installer

STEPS TO REPRODUCE:
1. run the full installer from:
ftp://ftp.mozilla.org/pub/mozilla.org/mozilla/nightly/latest-trunk/mozilla-i686-pc-linux-gnu-full-installer.tar.gz
2. click Next until you get to the "choose setup type" then choose "Custom"
3. Complete the installation process - I don't think it matters which tools you
   select to install (which is kind of odd because if I choose the "Complete"
   setup type then it works fine, but "Custom" with all tools selected fails.)
4. start Mozilla

ACTUAL RESULTS:
When Mozilla starts it shows a window with the text <dialog^ in it.
See screenshot.

EXPECTED RESULTS:
The "Select User Profile" dialog.

PLATFORMS and BUILDS TESTED:
Bug occurs in Mozilla 2005-02-26-05 trunk Linux.
The bug started a few days ago.

Comment 1

[Mats Palmgren (inactive)]

Attachment: Screenshot

Comment 2

[Mats Palmgren (inactive)]

This installer works:
http://ftp.mozilla.org/pub/mozilla.org/mozilla/nightly/2005-02-21-06-trunk/mozilla-i686-pc-linux-gnu-full-installer.tar.gz

This does not work:
http://ftp.mozilla.org/pub/mozilla.org/mozilla/nightly/2005-02-22-06-trunk/mozilla-i686-pc-linux-gnu-full-installer.tar.gz

Checkins in that window:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-02-21+04%3A00&maxdate=2005-02-22+08%3A00&cvsroot=%2Fcvsroot

Maybe caused by bug 242524?

Comment 3

[Andrew Schultz]

Attachment: patch

(thanks for catching this Mats)

the index owned by the component should have been nuked.  The component list
was just walking the list with a brute force search anyway.  This also removes
the paranoia that covered up this bug (made it fail silently instead of
crashing/providing an error message).

Comment 4

[Andrew Schultz]

oh, and I'm guessing that the custom setup type was not installing one of the
strings packages or something that resulted in the strange dialog.

Comment 5

[Andrew Schultz]

Attachment: left one out

the change to nsXInstaller is needed too to actually propogate the error

Comment 6

[Andrew Schultz]

Comment on attachment 175666 [details] [diff] [review]
left one out

no, no, no, no, no

Comment 7

[Andrew Schultz]

Attachment: the real thing

The component list was making the index into the component's position in its
list, which was wrong (and confusing).	The index is supposed to be the
component's position in the list of all components as they are parsed in
nsComponentsDlg.

Comment 8

[Daniel Veditz [:dveditz]]

Comment on attachment 175667 [details] [diff] [review]
the real thing

sr=dveditz

Comment 9

[Andrew Schultz]

FIXED

Comment 10

[Mats Palmgren (inactive)]

Verified using 2005-03-19-05