Closed
Bug 283923
Opened 19 years ago
Closed 19 years ago
remove useless test from nsImapProtocol::ProcessCurrentURL
Categories
(MailNews Core :: Networking: IMAP, defect)
MailNews Core
Networking: IMAP
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timeless)
References
()
Details
Attachments
(2 obsolete files)
i asked: what prevents that last marked line from crashing? ere answered: the fact that ProcessCurrentURL is actually only called if m_runningUrl is valid.. see http://lxr.mozilla.org/seamonkey/source/mailnews/imap/src/nsImapProtocol.cpp#1138 ere: I believe that test for m_runningUrl at 1263 is unnecessary
Attachment #175699 -
Flags: superreview?(bienvenu)
Attachment #175699 -
Flags: review?(bienvenu)
|
||
Comment 3•19 years ago
|
||
Comment on attachment 175699 [details] [diff] [review] remove null check seems OK - m_runningUrl should only get cleared on the imap thread.
Attachment #175699 -
Flags: superreview?(bienvenu)
Attachment #175699 -
Flags: superreview+
Attachment #175699 -
Flags: review?(bienvenu)
Attachment #175699 -
Flags: review+
Comment on attachment 175699 [details] [diff] [review] remove null check mozilla/mailnews/imap/src/nsImapProtocol.cpp 1.598
Attachment #175699 -
Attachment is obsolete: true
Attachment #175734 -
Attachment description: Networking patch for email protocol →
Attachment #175734 -
Attachment is obsolete: true
Attachment #175734 -
Attachment is patch: false
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
||
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•