284333 - SHGetMalloc API call is deprecated (in nsIEProfileMigrator.cpp)

Status: RESOLVED FIXED

(Core Graveyard :: Profile: Migration, defect)

Description

[David Gardiner]

According to the MSDN documentation
(http://msdn.microsoft.com/library/en-us/shellcc/platform/shell/reference/functions/shgetmalloc.asp)

"This function should no longer be used. Use the CoTaskMemFree and
CoTaskMemAlloc functions in its place"

This is used in:

/browser/components/migration/src/nsIEProfileMigrator.cpp, line 1236 -- result =
SHGetMalloc(&pMalloc);

-dave

Comment 1

[David Gardiner]

Attachment: Use CoTaskMemFree to release memory

Comment 2

[Mike Connor [:mconnor]]

Comment on attachment 176128 [details] [diff] [review]
Use CoTaskMemFree to release memory

looks good, I'll try to land this soon.

Comment 3

[Mike Connor [:mconnor]]

checked in using ::CoTaskMemFree per prevailing module style.

Thanks!