Closed
Bug 284364
Opened 20 years ago
Closed 20 years ago
Plugins don't work in window where midas has been enabled.
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
People
(Reporter: jst, Assigned: jst)
Details
Attachments
(1 file)
|
3.88 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
When enabling midas in a window, the editor turns off plugins, as it probably
should. The problem is that it never turns them on again when leaving the page.
Patch coming up.
|
Assignee | |
Comment 1•20 years ago
|
||
Attachment #175986 -
Flags: superreview?(bzbarsky)
Attachment #175986 -
Flags: review?(bzbarsky)
|
||
Comment 2•20 years ago
|
||
Comment on attachment 175986 [details] [diff] [review]
Turn on plugins when we're done editing.
>Index: editor/composer/src/nsEditingSession.cpp
>+ // Disable plugins in this document:
>+ rv = docShell->GetAllowPlugins(&tmp);
>+ NS_ENSURE_SUCCESS(rv, rv);
>+
>+ mPluginsEnabled = tmp;
>+
>+ rv = docShell->SetAllowJavascript(PR_FALSE);
>+ NS_ENSURE_SUCCESS(rv, rv);
s/Javascript/Plugins/ here, no?
r+sr=bzbarsky with that.
Attachment #175986 -
Flags: superreview?(bzbarsky)
Attachment #175986 -
Flags: superreview+
Attachment #175986 -
Flags: review?(bzbarsky)
Attachment #175986 -
Flags: review+
|
|
Assignee | |
Comment 3•20 years ago
|
||
Duh, yeah. Fix checked in.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•