Closed
Bug 284436
Opened 20 years ago
Closed 20 years ago
UMR [@ GenerateSingleByte]
Categories
(Core :: Internationalization, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timeless)
References
()
Details
Attachments
(1 obsolete file)
the following ranges seem to always be uninitialized:
mb[128..137,139,147-153]
purify doesn't like this, i don't like this, simon doesn't like this.
Attachment #176568 -
Flags: superreview?(bzbarsky)
Attachment #176568 -
Flags: review?(smontagu)
|
||
Comment 2•20 years ago
|
||
Comment on attachment 176568 [details] [diff] [review]
clear the middle block of mb
I'd like
memset(mb, 0, sizeof(mb));
before the first for loop much much better.
|
||
Comment 3•20 years ago
|
||
Comment on attachment 176568 [details] [diff] [review]
clear the middle block of mb
sr=bzbarsky either way.
Attachment #176568 -
Flags: superreview?(bzbarsky) → superreview+
Comment on attachment 176568 [details] [diff] [review]
clear the middle block of mb
r=smontagu
this is just fixing a UMR, it's low risk.
Attachment #176568 -
Flags: review?(smontagu)
Attachment #176568 -
Flags: review+
Attachment #176568 -
Flags: approval1.8b4?
|
||
Comment 5•20 years ago
|
||
Comment on attachment 176568 [details] [diff] [review]
clear the middle block of mb
Sure.
/be
Attachment #176568 -
Flags: approval1.8b4? → approval1.8b4+
Comment on attachment 176568 [details] [diff] [review]
clear the middle block of mb
mozilla/gfx/src/windows/nsFontMetricsWin.cpp 3.233
Attachment #176568 -
Attachment is obsolete: true
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•