Closed Bug 284436 Opened 19 years ago Closed 19 years ago

UMR [@ GenerateSingleByte]

Categories

(Core :: Internationalization, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

References

()

Details

Attachments

(1 obsolete file)

the following ranges seem to always be uninitialized:
mb[128..137,139,147-153]
purify doesn't like this, i don't like this, simon doesn't like this.
Attached patch clear the middle block of mb (obsolete) — Splinter Review
Attachment #176568 - Flags: superreview?(bzbarsky)
Attachment #176568 - Flags: review?(smontagu)
Comment on attachment 176568 [details] [diff] [review]
clear the middle block of mb

I'd like
memset(mb, 0, sizeof(mb));
before the first for loop much much better.
Comment on attachment 176568 [details] [diff] [review]
clear the middle block of mb

sr=bzbarsky either way.
Attachment #176568 - Flags: superreview?(bzbarsky) → superreview+
Comment on attachment 176568 [details] [diff] [review]
clear the middle block of mb

r=smontagu

this is just fixing a UMR, it's low risk.
Attachment #176568 - Flags: review?(smontagu)
Attachment #176568 - Flags: review+
Attachment #176568 - Flags: approval1.8b4?
Comment on attachment 176568 [details] [diff] [review]
clear the middle block of mb

Sure.

/be
Attachment #176568 - Flags: approval1.8b4? → approval1.8b4+
Comment on attachment 176568 [details] [diff] [review]
clear the middle block of mb

mozilla/gfx/src/windows/nsFontMetricsWin.cpp	3.233
Attachment #176568 - Attachment is obsolete: true
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: