28460 - Box layout does not provide consistent sizes

Status: VERIFIED FIXED

(Core :: XUL, defect, P1)

Description

[rods (gone)]

Box layout is not providing the combobox with a consistent sizes for 
aReflowState.mComputedWidth (or availableWidth). When the mail compose window 
displays the last mComputedWidth size as the the "From" Combobox gets layed 
out it is "4269", then on a mouse down the mComputedWidth is "5022".

The 5022 is an incremental reflow targeted at the ListControlFrame that is a 
child (popup list child so it doesn't get reflowed automatically) of the 
ComboboxControlFrame. In normal HTML layout the incoming mComputedWidth and 
availableWidth are both UNCONSTRAINED.

Here is my debug output:
nsCCF - nsComboboxControlFrame
nsLCF - nsListControlFrame
----------------------------------------------------
OnEndDocumentLoad
03C5F98C ** nsCCF::Reflow 15 R: Resize AW: 4329 AH: UNC CW: 4269 CH: 270 NO: 2 *

**Constrained WW: 4029  HH: 240
DW: 345
03C5FA54 ** nsLCF::Reflow 19 R: Resize AW: 345 AH: UNC CW: 345 CH: UNC
** Done nsLCF DW: 345  DH: 540
[[[[ CW: 4269 30 30
** Done nsCCF DW: 4329  DH: 330
Lost focus.
nsWebShellWindow::GOTFOCUS
set focus on the recipient
WEBSHELL+ = 7
Lost focus.
Lost focus.
nsWebShellWindow::GOTFOCUS
--------------------------- MouseDown ----------------------------
03C5F98C ** nsCCF::Reflow 16 R: Increm AW: 5082 AH: UNC CW: 5022 CH: 270 NO: 2 *

-----------------Target is Dropdown or it's child------------
03C5FA54 ** nsLCF::Reflow 20 R: StyleC AW: UNC AH: UNC CW: UNC CH: UNC
** Done nsLCF DW: 3675  DH: 540
|** Done nsCCF DW: 4329  DH: 330
--------------------------- MouseUp ----------------------------
03C5F98C ** nsCCF::Reflow 17 R: Increm AW: 5082 AH: UNC CW: 5022 CH: 270 NO: 2 *

-----------------Target is Dropdown or it's child------------
03C5FA54 ** nsLCF::Reflow 21 R: StyleC AW: UNC AH: UNC CW: UNC CH: UNC
** Done nsLCF DW: 3675  DH: 540
|** Done nsCCF DW: 4329  DH: 330
--------------------------- MouseUp ----------------------------
Lost focus.

Comment 1

[Peter Trudelle]

reassign to hyatt until evaughan gets back, cc evaughan. 

Comment 2

[Peter Trudelle]

Rod, I thought you said this was a blocker.  If so, please set severity 
accordingly, and add beta1 keyword.

Comment 3

[David Hyatt]

Eric can deal with this when he returns from vacation.  I'm not comfortable 
trying to fix the box code when it just got rewritten.

Comment 4

[rods (gone)]

*** Bug 28463 has been marked as a duplicate of this bug. ***

Comment 5

[rods (gone)]

I am blocked by this bug for my PDT+ bug, adding hyatt and trudelle to cc list

Comment 6

[rods (gone)]

*** Bug 28656 has been marked as a duplicate of this bug. ***

Comment 7

[rods (gone)]

forgot to document that I changed it to beta1 and "blocker"

Comment 8

[rods (gone)]

added 27881 as a dependency

Comment 9

[leger]

Putting on PDT+ radar for beta1.

Comment 10

[rods (gone)]

I have worked around a few of the issues, but I am not blocked by this:

When an item gets added to an option in XUL via RDF and and the dialog is using 
box layout. An incremental reflow is generated for the option (item) and the 
incremental reflow comes in with avilableWidth/height and mComputedWidth/Height 
set to the value of the last reflow when the combobox had no items. Eventually, 
a resize reflow comes through with the correct values, but it is still causing 
problems.

Comment 11

[Peter Trudelle]

Don't you mean "but I _am_ blocked by this:"?

Comment 12

[Eric Vaughan]

fixed

Comment 13

[Eric Vaughan]

fixed

Comment 14

[rods (gone)]

I am now sizing correctly to 2925 twips or 195 pixels which matches the 
horizontal spring for the example I will attach.

The problem is: when I click on the combobox I first correctly get an 
unconstrained incremental reflow and then (wrongly) I get an dirty reflow with 
the availWidth and computed width set to 3117 twips or 207.8 pixels. This value 
is wrong. This is what I have always been seeing. The mouse down reflows with 
the wrong computed and avilable size.

Comment 15

[rods (gone)]

Attachment: better XUL example

Comment 16

[rods (gone)]

If you need to test with my tree, go to spears-3 and grab these directories:
layout\html\forms
layout\html\content
layout\html\style

Comment 17

[rods (gone)]

Attachment: patch file for my current layout changes

Comment 18

[rods (gone)]

On MouseDown and MouseUp in HTML layout I just get an Inremental reflow, in Box 
I get Incremental and then a Dirty. 
Not only do I NOT need the Dirty it is the one that is sending me the wrong 
size.

Comment 19

[Eric Vaughan]

Rods stuff now works.

Comment 20

[Paul MacQuiddy]

spam: QA contact to jrgm (PDT+ resolved to be verified)

Comment 21

[John Morrison]

rods : can you verify that this is now working correctly. Thanks.

Comment 22

[rods (gone)]

As far as I can tell this is fixed.

Comment 23

[John Morrison]

Thanks Rod. marking verified.