Closed
Bug 284757
Opened 21 years ago
Closed 21 years ago
nsMsgAccountManager needs to LoadAccounts before searching for or creating new accounts
Categories
(SeaMonkey :: MailNews: Account Configuration, defect)
SeaMonkey
MailNews: Account Configuration
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: shaver, Assigned: shaver)
Details
Attachments
(1 file)
3.68 KB,
patch
|
Bienvenu
:
review+
mscott
:
superreview+
|
Details | Diff | Splinter Review |
If you happen to call into getAccount or (worse) createAccount before another
operation has triggered a LoadAccounts, you can get false negatives from the
account manager. In the case of getAccount, that's annoying, but in the case of
createAccount can lead to duplicate account names, which in turn causes us no
end of grief later on.
Simplest solution is to make sure that we call LoadAccount from GetAccount and
createUnique*Key; patch to that effect coming right up.
Assignee | ||
Comment 1•21 years ago
|
||
Pretty trivial, improves my lot quite a bit.
Attachment #176277 -
Flags: superreview?(mscott)
Attachment #176277 -
Flags: review?(bienvenu)
![]() |
||
Comment 2•21 years ago
|
||
Comment on attachment 176277 [details] [diff] [review]
As promised.
weird that it was a static method...must be historical...
Attachment #176277 -
Flags: review?(bienvenu) → review+
![]() |
||
Updated•21 years ago
|
Attachment #176277 -
Flags: superreview?(mscott) → superreview+
Assignee | ||
Comment 3•21 years ago
|
||
Checked this in, I do believe.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•