Closed Bug 28483 Opened 25 years ago Closed 24 years ago

numbered list conversion to roman numerals starts new sublist

Categories

(Core :: DOM: Editor, defect, P1)

defect

Tracking

()

VERIFIED WORKSFORME

People

(Reporter: sujay, Assigned: cmanske)

References

Details

(Whiteboard: [nsbeta2+][5/16]Composer feature work)

using 2/18 build of mozilla

1) launch mozilla
2) launch editor
3) enter some text
4) make it a numbered list
5) hit carriage return forcing more lines of numbered list items
6) click in any of list items
7) Format | List Properties 
8) change to Roman numerals(uppercase)
9) click OK

notice it doesn't convert the original list to Roman numerals, instead
just adds roman numeral list items after the last numbered list item.

I expected it to change the list to roman numerals...
all platforms.
reassign to cmanske for initial triage; Charley if we can't get this dialog 
working for beta1 I think we should disable this menu item.
Assignee: jfrancis → cmanske
Target Milestone: M15
Fix looks straightforward: We are calling "MakeOrChangeList" all the time,
which is what causes the new sublist to appear. Then the new attributes are
applied only to that new sublist.
We should simply not call MakeOrChangeList if the current list type is the same
as what we started with. 
Proposing for PDT approval for Beta1
Status: NEW → ASSIGNED
Keywords: beta1
Summary: numbered list conversion to roman numerals messes up list → numbered list conversion to roman numerals starts new sublist
Target Milestone: M15 → M14
Putting on PDT- radar for beta1. 
Whiteboard: [PDT-]
move to M15
Target Milestone: M14 → M15
Keywords: beta1
Whiteboard: [PDT-]
load balancing
Target Milestone: M15 → M16
This will be fixed as part of list dialog rewrite for skins.
Depends on: 19565
this bug has been deemed as beta2 feature work by the Composer team. Updated 
priority, severity, whiteboard and keyword.
Severity: normal → major
Keywords: beta2
Priority: P3 → P1
Whiteboard: Composer feature work
Keywords: nsbeta2
With Joe's recent fixes in list editing behavior, this now works great!
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
still not working....
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Putting on [nsbeta2+][5/16] radar.  This is a feature MUST complete work by 
05/16 or we may pull this feature for PR2.
Whiteboard: Composer feature work → [nsbeta2+][5/16]Composer feature work
this works in my debug build updated as of today. The optimized builds looked
horked -- e.g., all menulists are collapsed into a thin line. Not sure if 
what's up.
Status: REOPENED → ASSIGNED
This still works fine in my debug build. Have problems cleared up in release
builds yet?
Sujay sees that this is ok now.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago24 years ago
Resolution: --- → WORKSFORME
verified in 5/16 build.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.