Closed
Bug 285048
Opened 19 years ago
Closed 19 years ago
nsImageWin::ConvertDDBtoDIB uses wrong color depth
Categories
(Core Graveyard :: GFX: Win32, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.8beta2
People
(Reporter: Biesinger, Assigned: Biesinger)
References
Details
Attachments
(1 file)
891 bytes,
patch
|
emaijala+moz
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
ConvertDDBtoDIB passes the color depth of the DDB to BuildDIB. That's wrong - callers of nsImageWin::GetBits expect the color depth to be whatever nsImageWin currently uses (24bpp, usually). So, this function should pass mNumBytesPixel*8 to BuildDIB.
Assignee | ||
Comment 1•19 years ago
|
||
Attachment #176515 -
Flags: review?(emaijala)
Assignee | ||
Updated•19 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.8beta2
Assignee | ||
Updated•19 years ago
|
Priority: -- → P2
Comment 2•19 years ago
|
||
Comment on attachment 176515 [details] [diff] [review] patch If mNumBytesPixel is bytes as the name implies, you shouldn't multiply it. If it's actually bits, please fix the variable name.
Attachment #176515 -
Flags: review?(emaijala) → review-
Assignee | ||
Comment 3•19 years ago
|
||
Comment on attachment 176515 [details] [diff] [review] patch mNumBytesPixel is what it says; but I still need to multiply it, since BuildDIB expects bits per pixel, not bytes...
Attachment #176515 -
Flags: review- → review?(emaijala)
Comment 4•19 years ago
|
||
Comment on attachment 176515 [details] [diff] [review] patch Sorry, you're right :/ Note to self: don't do reviews early in the morning.
Attachment #176515 -
Flags: review?(emaijala) → review+
Assignee | ||
Updated•19 years ago
|
Attachment #176515 -
Flags: superreview?(roc)
Attachment #176515 -
Flags: superreview?(roc) → superreview+
Assignee | ||
Comment 5•19 years ago
|
||
Checking in gfx/src/windows/nsImageWin.cpp; /cvsroot/mozilla/gfx/src/windows/nsImageWin.cpp,v <-- nsImageWin.cpp new revision: 3.142; previous revision: 3.141 done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Updated•15 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•