Closed Bug 285163 Opened 19 years ago Closed 19 years ago

Download dialog source spoofing (Secunia Advisory SA13599 less critical)

Categories

(SeaMonkey :: Download & File Handling, defect)

Product:
SeaMonkey
Component:
Download & File Handling
Version:
1.7 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: caillon, Assigned: neil)

References

(
URL
)

Details

(Keywords: fixed1.7.6, verified1.7.6, Whiteboard: [sg:spoof])

Attachments

(1 file, 1 obsolete file)

v2
2.40 KB, patch
caillon
: review+
dveditz
: superreview+
dveditz
: approval1.7.6+
Details | Diff | Splinter Review 
This is the SeaMonkey equivalent of bug 275417.  See that bug for details.
Need this for 1.7.6 and beta2.
Flags: blocking1.8b2+
Flags: blocking1.7.6+
Whiteboard: [sg:spoof]
As an alternative to changing the textbox to a description we could use
textbox.controllers.getControllerForCommand("cmd_endLine").doCommand("cmd_endLine");
to scroll the textbox.
Neil, I suppose its your call.  Either way, we need a fix quickly.  Think you
can whip up a patch?
Attached patch v1 (obsolete) — — Splinter Review 
Note that the user:pass are not displayed in the tooltip in this version.
Assignee: dveditz → neil.parkwaycc.co.uk
Status: NEW → ASSIGNED
Attachment #176742 - Flags: superreview?(dveditz)
Attachment #176742 - Flags: review?(caillon)
Comment on attachment 176742 [details] [diff] [review]
v1

I think this looks good.  r=caillon
Attachment #176742 - Flags: review?(caillon) → review+
Attached patch v2 — — Splinter Review 
Whoops, I missed out the third hunk - that's what you get for having too many
pending patches on the same tree :-[
Attachment #176742 - Attachment is obsolete: true
Attachment #176782 - Flags: superreview?(dveditz)
Attachment #176782 - Flags: review?(caillon)
Attachment #176782 - Flags: review?(caillon) → review+
Attachment #176742 - Flags: superreview?(dveditz)
Comment on attachment 176782 [details] [diff] [review]
v2

sr=dveditz, a=drivers from mtg.
Attachment #176782 - Flags: superreview?(dveditz)
Attachment #176782 - Flags: superreview+
Attachment #176782 - Flags: approval1.7.6+
I just landed this on the 1.7 branch for Neil.  It still needs a trunk checkin.
Keywords: fixed1.7.6
Fix checked in to the trunk.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Verified Fixed using testcase from bug 278186 with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.6) Gecko/20050310

Host is cropped on the left, correctly displaying "secunia.com" on the right.
Status: RESOLVED → VERIFIED
mistakenly removed fixed1.7.6 --pardon the bugspam. set your filter/quicksearch
to "ZippidityDooDahHey" to catch these for easy removal/etc/
Keywords: fixed1.7.6
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: