285165 - Fix remaining float containment issues (BuildFloatList removal)

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

From Boris in https://bugzilla.mozilla.org/show_bug.cgi?id=267037#c4

I just looked at all callers of PushFloatContainingBlock in the frame
constructor.  The following still wouldn't get flagged (as far as I can tell)
as containing blocks by GetFloatContainingBlock after this patch:

1)  An SVGOuterFrame if the documentElement is <svg:svg>.  Given that
    that's not a blockframe, the fact that it's pushed at all is probably
    a bug...
2)  The scrolled frame inside a select (not sure about this one; see
    InitializeSelectFrame()).
3)  SVG <foreignObject> frames (since we'll actually create a blockframe
    no matter what the display value of the node is).

May be worth filing separate bugs on the SVG issues, I guess, but we should
sort out whether <select> is a problem (that is, whether the display of the
scrolled content there will be block).

Comment 1

[Boris Zbarsky [:bzbarsky]]

Fixed by patch in bug 283385