285651 - Opening link in new background tab confuses screen readers

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

Steps:
1. Load Window-Eyes and Mozilla or Firefox
2. While on a link, hit Ctrl+Enter

Window-Eyes gets stuck in "downloading page" mode.

We should not fire our page load events for pages other than the currently
focused page.

Comment 1

[Aaron Leventhal]

Attachment: 1) Only addProgressListener() on content, 2) Only listen to state changes, 3) Don't fire state_change events for loads in other documents

This also fixes the extra "loading page" that Window-Eyes was saying when
Firefox is launched.

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 177097 [details] [diff] [review]
1) Only addProgressListener() on content, 2) Only listen to state changes, 3) Don't fire state_change events for loads in other documents

+    mWebProgress->GetIsLoadingDocument(&isLoading);

hm, the isLoading variable seems write-only. can it be removed?

Other than that... the change looks ok to me... but I don't know the
accessibility code very well... r=biesi, but it would be great if you could get
sr, or another r, from someone knowing this code.

Comment 3

[Aaron Leventhal]

Comment on attachment 177097 [details] [diff] [review]
1) Only addProgressListener() on content, 2) Only listen to state changes, 3) Don't fire state_change events for loads in other documents

Biesi, thanks for noticing the extra unneeded isLoading in AddEventListeners().
I'll remove that.

Comment 4

[Aaron Leventhal]

Attachment: Remove extra unneeded GetIsLoadingDocument() calls. Carrying biesie's r+

Comment 5

[Aaron Leventhal]

Checking in src/base/nsDocAccessible.cpp;
/cvsroot/mozilla/accessible/src/base/nsDocAccessible.cpp,v  <--  nsDocAccessible.cpp
new revision: 1.52; previous revision: 1.51
done
Checking in src/msaa/nsDocAccessibleWrap.cpp;
/cvsroot/mozilla/accessible/src/msaa/nsDocAccessibleWrap.cpp,v  <-- 
nsDocAccessibleWrap.cpp
new revision: 1.24; previous revision: 1.23
done