28572 - On unload fires when link opens in different frame or window

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[aarons]

on pages with the following code
if (clicked==0)
Refering to any object on the page the action actually performed by the browser 
is equal to the value true of that statement. for example if it would be 
follwed by window.open the window would always open regardles what was actually 
done by the user.
This bug exists in version 2000021908.
I have been unable to verify whether this is a problem with a return value or 
the engine possibly ignoring the if part of the statement.

Comment 1

[Richard Zach]

Do you have a testcase?  Example URL?

Comment 2

[Richard Zach]

After email from [e-mail], I think I understand now.  The problem
is that an unload event is triggered whenever a link is followed, even if the
page or frame itself is not unloaded (as when the link loads a page into a
different frame).  

Attaching a testcase.  Setting component to DOM0, reassign to vidur, cc: karnaze
for the frames angle.  Works as expected in NS 4.7.

To reproduce: 
1. Open frameset.html.  This loads click.html into right frame.  
2. Click on the link.  

Actual result: loads mozilla.org into the left frame, does not unload the right
frame.  Still, unload fires.
Expected result: no unload event, since frame is not unloaded.

Similarly, if you open just click.html and select the link, mozilla.org will
open in a new window, the old window does not unload, but unload event fires
nevertheless.

Comment 3

[Richard Zach]

Attachment: Testcase: save as frameset.html

Comment 4

[Richard Zach]

Attachment: Testcase: save as click.html

Comment 5

[vidur (gone)]

Passing along to Travis since the link handling code and onunload firing is 
currently in his neck of the woods. Travis, consult with Tom Pixley or me if you 
have questions about when onunload should fire for compatibility with 4.x.

Comment 6

[ekrock's old account (dead)]

Nominating nsbeta2. We have to start drawing a line on DOM0 backward 
compatibility; these bugs are supposed to be a high priority for nsbeta2 per the 
beta2 criteria.

Comment 7

[leger]

ekrock - do you have a top 100 site that this occurs on?

Comment 8

[Peter Trudelle]

[nsbeta2+]

Comment 9

[Prashant Desale]

I think the basic problem is as explianed by Richard Zach. Unload Event fires 
even if Unload of window does not occur.
You can see just by loading second attachment provided by Richard. Even if we 
just click on link, still ubload event takes place. [Which is wrong]
We are not even closing window.
seems like pretty important to be fixed for beta2.

Comment 10

[Judson Valeski]

-> m16?

Comment 11

[Judson Valeski]

Attachment: proposed fix

Comment 12

[Mike]

M16 has been out for a while now, these bugs target milestones need to be 
updated.

Comment 13

[Judson Valeski]

-> potts

Comment 14

[rpotts (gone)]

-> jst

Johnny has agreed to look at my onLoad/onUnload bugs while I'm gone...

Comment 15

[Johnny Stenback (:jst)]

Accepting bug, Valeski, any particular reason as to why the proposed fix hasn't
been checked in?

Comment 16

[Judson Valeski]

cc'ing vidur who I initially talked to about this. Potts was going to overhaul 
all of this and hasn't gotten around to it. I suspect my change is a hacky 
workaround.

Comment 17

[Johnny Stenback (:jst)]

I just checked in a fix for this problem, the fix is only a modified version of
the attached patch, I'll leave the big overhaul to rpotts, but the immediate
problem with the unload event is fixed. Marking FIXED.

Comment 18

[Prashant Desale]

I just tested this one with 08-01-04, and it is working perfect. Unload is not 
firing on following the link.