285911 - XPrint hardcodes english string with literal "Mozilla"

Status: RESOLVED FIXED

(Core Graveyard :: Printing: Xprint, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

this string was added by gisburn in Bug 72087.
http://lxr.mozilla.org/seamonkey/source/gfx/src/xprint/nsXPrintContext.cpp#859
has a hardcoded english string... it should not contain a literal Mozilla, and
it should be localizable.

Comment 1

[Peter Weilbacher]

Attachment: rebrand xprint fallback job title

AFAIU the code normal users will never see the string because it just sets the
print job title as a fallback when the document title couldn't be determined
(much like the JS console gives error messages in English even on a localized
install). Changing it to full localization would probably be overkill.

So this patch just changes the appname similarly to the changes in
xpfe/bootstrap/. If I could get Xprint running I could actually test that is
does what I think it does. At least it compiles.

Comment 2

[Peter Weilbacher]

Attachment: more correct change for rebranding

Ahem, sorry. This one is probably more like it...

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

this sucks from a GRE viewpoint... maybe it should be just "Document without title"?

Comment 4

[Peter Weilbacher]

Attachment: Just remove "Mozilla" from the string (Checked in)

Do you mean that if GRE is shipped seperately MOZ_APP_DISPLAYNAME will not be
defined? Anyway, here is the one line patch to just remove "Mozilla". Use
whichever you think is best. :-)

Comment 5

[chris hofmann]

lets get this reviewed and checked-in early in the beta3 cycle.

Comment 6

[Ian Neal]

Comment on attachment 183036 [details] [diff] [review]
Just remove "Mozilla" from the string (Checked in)

No sign of roland

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 183036 [details] [diff] [review]
Just remove "Mozilla" from the string (Checked in)

approving trivial fix

Comment 8

[Ian Neal]

Comment on attachment 183036 [details] [diff] [review]
Just remove "Mozilla" from the string (Checked in)

Checking in gfx/src/xprint/nsXPrintContext.cpp;
new revision: 1.52; previous revision: 1.51
done